Skip to content

aria-haspopup no-incompatible-type-binding false alarm #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

aria-haspopup no-incompatible-type-binding false alarm #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e700df
aria-haspopup no-incompatible-type-binding false alarm
joekukish Jun 9, 2021
64b02f1
aria-haspopup no-incompatible-type-binding false alarm
joekukish Jun 30, 2021
cb60e27
Merge branch 'master' into 142
joekukish Feb 25, 2022
5e678af
Updated to latest vscode-web-custom-data dependency.
joekukish Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/lit-analyzer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@
"fast-glob": "^2.2.6",
"parse5": "5.1.0",
"ts-simple-type": "~1.0.5",
"vscode-css-languageservice": "4.3.0",
"vscode-html-languageservice": "3.1.0",
"vscode-web-custom-data": "^0.3.0",
"vscode-css-languageservice": "4.4.0",
"vscode-html-languageservice": "3.2.0",
"vscode-web-custom-data": "^0.3.6",
"web-component-analyzer": "~1.1.1"
},
"devDependencies": {
Expand Down
10 changes: 10 additions & 0 deletions packages/lit-analyzer/src/test/rules/no-incompatible-type-binding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,16 @@ tsTest("Attribute binding: Boolean type expression (false) is assignable to 'tru
hasNoDiagnostics(t, diagnostics);
});

tsTest("Attribute binding: Non boolean expression (dialog) is assignable to aria-haspopup", t => {
const { diagnostics } = getDiagnostics('html`<input aria-haspopup="dialog" />`');
hasNoDiagnostics(t, diagnostics);
});

tsTest("Attribute binding: Random string literal is not assignable to aria-haspopup", t => {
const { diagnostics } = getDiagnostics('html`<input aria-haspopup="test" />`');
hasDiagnostic(t, diagnostics, "no-incompatible-type-binding");
});

tsTest("Attribute binding: Union of 'string | Directive' type expression is assignable to string", t => {
const { diagnostics } = getDiagnostics('type DirectiveFn = {}; html`<input placeholder="${{} as string | DirectiveFn}" />`');
hasNoDiagnostics(t, diagnostics);
Expand Down