Skip to content

Update WCA, typescript and internal dependencies #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Update WCA, typescript and internal dependencies #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0d0967c
Update TypeScript to 3.9 and tighten version range
justinfagnani Sep 10, 2021
5bf093c
WIP
justinfagnani Sep 10, 2021
1771029
Update WCA, typescript and internal dependencies
justinfagnani Sep 15, 2021
b8015a9
Copy syntax files into repo, remove install:safe script
justinfagnani Sep 15, 2021
b8fb739
Update package lock
justinfagnani Sep 15, 2021
3c1a612
Update eslint typescript
justinfagnani Sep 15, 2021
1a29c4c
Update web-component-analyzer
justinfagnani Sep 16, 2021
3bf76ec
Update WCA in vscode-lit-plugin
justinfagnani Sep 16, 2021
33e3f1c
Re-install vsce to update package-lock
justinfagnani Sep 16, 2021
b2b4ba2
Don't ignore lit-plugin in bootstrap script
justinfagnani Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:

- name: Package vscode plugin
if: matrix.os == 'ubuntu-latest'
run: npx lerna run install:safe --scope lit-plugin && npx lerna run package --scope lit-plugin && mkdir vscode-lit-plugin && mv packages/vscode-lit-plugin/lit-plugin-*.vsix vscode-lit-plugin
run: npx lerna run package --scope lit-plugin && mkdir vscode-lit-plugin && mv packages/vscode-lit-plugin/lit-plugin-*.vsix vscode-lit-plugin

- name: Upload artifacts
uses: actions/upload-artifact@master
Expand Down
4 changes: 0 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ In order to debug `vscode-lit-plugin` you can open vscode from `packages/vscode-

You can use this script if you want to generate an installable package of vscode-lit-plugin. You can install the bundled package from vscode.

### `npm run install:safe`

Some dependencies are installed directly from Github URLs (see [syntaxes](#syntaxes)). In order to prevent `postinstall` scripts to run when installing these dependencies (which will crash), they are installed with `--ignore-scripts`. `npm run bootstrap` will make sure to execute `install:safe` when running.

### `npm run copylink` (main package.json)

VS Code doesn't support debugging symlinked dependencies. Therefore there are no symlinked dependencies in `packages/vscode-lit-plugin`. This means that local changes to `lit-analyzer` are not automatically reflected when debugging `vscode-lit-plugin`.
Expand Down
Loading