Skip to content

Conversation

@markmiro
Copy link
Contributor

Screen.Recording.2025-09-29.at.9.20.58.AM.mov

@rgbkrk
Copy link
Member

rgbkrk commented Oct 7, 2025

This has to move a little higher up and based on it being an actual error output otherwise it will put a fix code button on every stderr output, like if a library emits logs on stderr using sys.stderr.write (or otherwise)

image

@markmiro markmiro marked this pull request as draft October 14, 2025 15:25
@markmiro
Copy link
Contributor Author

This has to move a little higher up and based on it being an actual error output otherwise it will put a fix code button on every stderr output, like if a library emits logs on stderr using sys.stderr.write (or otherwise)

image

Can you double-check? I think it is handling errors properly. We have separate components for AnsiStreamOutput and AnsiErrorOutput, which is used for "error messages and tracebacks"

https://github.com/runtimed/anode/blob/2da6049921a409fed535375caf8a643d11dab53e/src/components/outputs/shared-with-iframe/AnsiOutput.tsx#L60

@markmiro markmiro marked this pull request as ready for review October 14, 2025 16:31
queueId: `exec-${Date.now()}-${Math.random().toString(36).slice(2)}`,
executionCount:
store.query(queries.cellQuery.byId(newCellId))?.executionCount ||
0 + 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not have to pass an execution count into the requested execution. That's probably a mistake in the schema. I'm seeing this plain as day being incorrect.

Either we need a new event for execution requested or see if this is optional.

@rgbkrk
Copy link
Member

rgbkrk commented Oct 14, 2025

From call -- we can probably take all the iframe bits out of this and move the fix code button into the cell itself (somewhere?) as we can detect if there's an error in the outputs.

@markmiro markmiro merged commit 32e7c1f into main Oct 16, 2025
2 checks passed
@rgbkrk rgbkrk deleted the fix-code branch October 24, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants