Optimise StrExt::replace_smolstr
, StrExt::replacen_smolstr
for single ascii replace
#100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports a single ascii fast path optimisation from std str::replace highlighted by benchmarks in #96. I also made it a little more general applying to both
StrExt::replace_smolstr
&StrExt::replacen_smolstr
.PR bench
The change provides a significant perf improvement particularly for inline reprs. Also faster than String for len=12 now 🙂 (I measured previously as 10.8ns).