Remove usage of secp256k1_context_no_precomp #862
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
push-xzumovxmmtqq
branch
from
a8482e9 to
7d35501
Compare
Now that we don't need to pass the context into APIs we can remove the usage of `secp256k1_context_no_precomp` which was specifically used to avoid the context. Close rust-bitcoin#846
tcharding
force-pushed
the
push-xzumovxmmtqq
branch
from
7d35501 to
b287fd5
Compare
|
FWIW the test passes locally for me. |
|
Yep, concept ack. This particular test is unstable. If I had to guess at the frequency, I'd say it fails 1 in 32 times or so. |
stevenroose
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before I grind this out can you concept ack please @andrew. I just did
ecdhto see if I have the right idea.Now that we don't need to pass the context into APIs we can remove the usage of
secp256k1_context_no_precompwhich was specifically used to avoid the context.Close #846