allow setting nvcc program via CUDACXX
#997
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusDunn
changed the title
nvcc program via CUDA_CXXnvcc program via CUDACXX
NobodyXu
requested changes
Mar 7, 2024
| @@ -2402,7 +2404,8 @@ impl Build { | |||
| let dlink = out_dir.join(lib_name.to_owned() + "_dlink.o"); | |||
| let mut nvcc = self.get_compiler().to_command(); | |||
| nvcc.arg("--device-link").arg("-o").arg(&dlink).arg(dst); | |||
| run(&mut nvcc, "nvcc", &self.cargo_output)?; | |||
| let program = env::var("CUDACXX").unwrap_or_else(|_| String::from("nvcc")); | |||
There was a problem hiding this comment.
I think you might need to modify cc::Build::get_base_compiler.
This line you modified is for linking with cuda-specific part only.
P.S. I'm not so familiar with the cuda compilation part, so feel free to point out any mistake.
There was a problem hiding this comment.
I suspected this was too easy. I'll take a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know how the tests works (pointers welcome if you'd like a test).
How the other's (
CCandCXX) get initialized seems very complex to support stuff likeccache cc. This is about as simple as could be.Resolves #995