Format meta-style attributes with general expressions #6653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements formatting of most attributes that follow the general meta format from the reference, rather than just
ast::MetaItem
-style attributes (which are restricted to using literals in their expressions).The code to implement this uses its own AST structs and enums inspired by
rustc_ast
. It uses speculative parsing in meta lists to distinguish nested meta items from expressions by parsing as the latter if the former fails. Rustfmt already parses macro arguments using an approach similar to this.