Clarify installation process dependencies #4599
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
reviewed
Nov 14, 2025
| Err(e) => return Some(Err(e)), | ||
| }; | ||
|
|
||
| match target_package.bins.is_empty() { |
Member
There was a problem hiding this comment.
Nit: Existing, but when looking at this I realized that maybe this could be matched as &target_package.bins against [] or [binary, ..]? It's true that using match rather than if-else would help spotting such issues.
rami3l
approved these changes
Nov 14, 2025
Member
rami3l
left a comment
rami3l
left a comment
There was a problem hiding this comment.
Looks pretty cool, thanks a lot :)
src/dist/component/package.rs
Outdated
| use std::ops::Deref; | ||
| use std::path::{Path, PathBuf}; | ||
| use std::sync::OnceLock; | ||
| use std::{env, mem}; |
Member
There was a problem hiding this comment.
Nit: RA likes to suggest stuff like that. When this happens I just merge the imports altogether. This change seems to be unused?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.