template: Update to dioxus 0.4/wry 0.28 with libwebkit2gtk-4.1-dev
#210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dvc94ch you PR'd tauri-apps/wry#829, is this change correct on the |
We've been getting deprecation warnings in the CI that Ubuntu 22.04 is going to be replaced with Ubuntu 24.04 soon for the `ubuntu-latest` image. That happened just a few days ago, and now the CI complains that `libwebkit2gtk-4.0-dev` can no longer be found in Ubuntu Noble's APT repositories. We have to upgrade to `4.1`, which can be achieved by using at least `wry 0.25`: tauri-apps/wry@c5f3b36 This is used by `dioxus 0.4`, which is the target of this upgrade. As I am not a user of any of the `wry`/`dioxus` functionality inside `xbuild` (and if not for me, it doesn't look like anyone else is maintaining or caring about this either), I kept this upgrade as small as possible and didn't upgrade to `dioxus 0.6.1` (the latest as of writing) which might incur more breaking changes and require testing which I'm not inclined to perform. All I really need is the CI to succeed again :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been getting deprecation warnings in the CI that Ubuntu 22.04 is going to be replaced with Ubuntu 24.04 soon for the
ubuntu-latestimage.That happened just a few days ago, and now the CI complains that
libwebkit2gtk-4.0-devcan no longer be found in Ubuntu Noble's APT repositories. We have to upgrade to4.1, which can be achieved by using at leastwry 0.25: tauri-apps/wry@c5f3b36This is used by
dioxus 0.4, which is the target of this upgrade. As I am not a user of any of thewry/dioxusfunctionality insidexbuild(and if not for me, it doesn't look like anyone else is maintaining or caring about this either), I kept this upgrade as small as possible and didn't upgrade todioxus 0.6.1(the latest as of writing) which might incur more breaking changes and require testing which I'm not inclined to perform. All I really need is the CI to succeed again :)