install rustup targets for MacOS and Windows #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 260df6e. The test in vmm-sys-util that wished to use this ended up not needing it, so remove it again to keep the docker container tidy. Signed-off-by: Patrick Roy <[email protected]>
roypat
requested review from
RuoqingHe,
ShadowCurse,
andreeaflorescu,
lauralt,
stefano-garzarella and
stsquad
as code owners
Some of the rust-vmm crates (such as vmm-sys-util and vm-memory) have somewhat rudimentary support for MacOS and Windows. While our CI does not have the means to test these platforms (the rust-vmm CI runners are linux-only), it can at least do some simple compile testing using `cargo check` (as long as we do not have any build dependencies that try to compile native libraries). For this, install the required cargo targets into the docker container, such that crates that wish to do such compile testing can specify such additional tests in their custom tests pipelines. Signed-off-by: Patrick Roy <[email protected]>
roypat
force-pushed
the
additional-targets
branch
from
a049046 to
0c7b147
Compare
stefano-garzarella
approved these changes
Jul 31, 2025
ShadowCurse
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Some of the rust-vmm crates (such as vmm-sys-util and vm-memory) have
somewhat rudimentary support for MacOS and Windows. While our CI does
not have the means to test these platforms (the rust-vmm CI runners are
linux-only), it can at least do some simple compile testing using
cargo check(as long as we do not have any build dependencies that try tocompile native libraries). For this, install the required cargo targets
into the docker container, such that crates that wish to do such compile
testing can specify such additional tests in their custom tests
pipelines.
While we're here, also revert #135, because we ended up not needing the utility.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.