virtio-queue: kani proofs for virtio queue #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyasiddharth
requested review from
alexandruag,
andreeaflorescu,
jiangliu,
slp,
stsquad,
epilys and
stefano-garzarella
as code owners
This simplifies the logic for the existing need_notification proof and makes it more general accounting for both when notification is needed and when it is not. Signed-off-by: Siddharth Priya <[email protected]>
1. Verify enable_notification logic 2. Verify when driver should send notification to device 3. Verify when driver should not send notification to device 4. Verify that set_next_used method actually changes the next_used field in memory Signed-off-by: Siddharth Priya <[email protected]>
priyasiddharth
force-pushed
the
main
branch
from
edd1731 to
24dc553
Compare
|
@MatiasVara FYI |
epilys
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This PR adds new Kani proofs for virtio queue mainly around notification logic.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.