Skip to content

Conversation

@markcda
Copy link

@markcda markcda commented Mar 14, 2025

No description provided.

@markcda markcda changed the title Update 'rand' to '0.9' Update cookie-rs (rand v0.9 & edition) Mar 14, 2025
version = "0.18.1"
authors = ["Sergio Benitez <[email protected]>", "Alex Crichton <[email protected]>"]
edition = "2018"
edition = "2024"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit too aggressive. Why bump MSRV to 1.85 when you're not benefiting from it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! We want to keep the MSRV as low as possible.

@SergioBenitez
Copy link
Member

Please limit your PR to updating rand. Specify as well what the new MSRV would be with this change, ideally by showing a failure to compile with version x - 1 and a successful compilation with x.

@JonathanWoollett-Light
Copy link

@SergioBenitez I've opened a PR just updating rand #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants