forked from heroku/heroku-buildpack-nginx
-
Notifications
You must be signed in to change notification settings - Fork 0
RFC major rewrite #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
agriffis
wants to merge
22
commits into
ryandotsmith:master
Choose a base branch
from
agriffis:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our server doesn't support use of domain sockets. |
+1 customizable nginx config file |
… best compromise of speed and efficiency.
@ryandotsmith If I put some work into rebasing this and resolving the issues I mentioned above, would you be interested in pulling it? IMHO the improvements here are pretty significant. I've been using my fork in production for the past couple years. |
Allow version of utilities to be set on environment
AVDiv
referenced
this pull request
in AVDiv/nginx-buildpack
Dec 23, 2022
Add NGINX_WORKER_CONNECTIONS env var to set worker_connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is NOT ready to be pulled. It breaks backward compatibility for existing users, and it diverges significantly from how this buildpack has historically worked. This pull request is for the sake of discussion leading to a series of sensible commits.
Major differences:
CACHE_DIR
between deploys with a version check to force rebuild. Alternatively the user can setNGINX_FORCE_BUILD
to ignore the cached binary./dev/stderr
as an output file, but Heroku makes this impossible, see http://stackoverflow.com/questions/22694530)PORT
is overridden to refer to the UNIX domain socket, so the application can detect whether it's running under NGINX or directly. This is especially because NGINX can be enabled or disabled at run-time by togglingNGINX_ENABLED
.NGINX_WAIT_ENABLED
(default1
) andNGINX_WAIT_FILE
(defaults to the value ofNGINX_SOCKET
which defaults to/tmp/nginx-socket
)Known breakage:
client_body_timeout 5;
from the default nginx.conf. Not clear what problem this is intended to solve.