-
Notifications
You must be signed in to change notification settings - Fork 366
feat: add 1.3.0 eip155 and canonical contracts for Incentiv Testnet #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 1.3.0 eip155 and canonical contracts for Incentiv Testnet #1231
Conversation
Looks like the RPC is reporting that the contracts are not deployed:
|
Thank you for the feedback. Okay, how can I check that all addresses will be deployed "OK"?
|
Hmm, not sure, but those addresses don't match the expected values at all. I would make sure to:
|
Deployed at the branch release/v1.3.0 and release/v1.4.1. Thank you for the help. Are addresses correct now? I have checked the addresses in the output directory called "deployments/custom" and all addresses were correct.
|
Yes, the 1.3.0 version addresses (which are under the note that this is the EIP-155 deployment (and not the canonical one), so the artifacts in the JSON need to be updated accordingly:
|
Updated with a new commit. "> @safe-global/[email protected] deploy-all" Yes, this label is used on the branch release/v1.3.0 in the package.json. What about the 1.4.1 version? I need to create a new PR? Our network supports the EIP-4337 protocol with AA implementation. |
Yes please! One PR per deployment. |
Add new chain
Please fill the following form:
Provide the Chain ID (Only 1 chain id per PR).
Relevant information:
PR Safe Singleton Factory
PR Chainlist
PR Etherscan