Added 1.4.1 canonical support

[Yolokos]

Add new chain

Please fill the following form:

Provide the Chain ID (Only 1 chain id per PR).

• Chain_ID: 28802

Relevant information:
PR Singleton Factory
PR Chainlist
PR Etherscan

I have tried such branches: release/v1.4.1, v1.4.1-2, v1.4.1-1. My addresses didn't change at all. I see CHANGELOG.md, but I have no idea why it was deployed to another address.

`> @safe-global/[email protected] deploy-all
> hardhat deploy-contracts --network custom     

Nothing to compile
No need to generate any newer typings.
reusing "SimulateTxAccessor" at 0xBe6BD378a99F9f67D09270e33580C2c8be456a20
reusing "SafeProxyFactory" at 0x7759ca2f14B0e6544e6F3a25330Fa34C1A79CBe8
reusing "TokenCallbackHandler" at 0xCb1764c55Cf6dbefAC7c0Cec00FCEAC39aa5c2ef
reusing "CompatibilityFallbackHandler" at 0x5b795bC69D292dd93961F2C9f1f15Deb4C7EFa8C
reusing "CreateCall" at 0x6204cA4282DCB6d59Ffd9DE7541298776680a13E
reusing "MultiSend" at 0x0e508e1795cE78892132d7399163924324090C1b
reusing "MultiSendCallOnly" at 0x2b845496846bD55BF60C2c63822d2e6df38a04B8
reusing "SignMessageLib" at 0x080BDF7e0A9816B1462E096750adBFA6563ee93A
reusing "SafeToL2Setup" at 0x0BaC5594D6F154D3621d166B9452F5d0B45b6513
reusing "Safe" at 0xFedc87F5f38142783f4db60f4eb1296F3ec7991e
reusing "SafeL2" at 0xb10738E34bFA5B29762c89AC212D03f185C33671
reusing "SafeToL2Migration" at 0x26592628a12D1004C9a788e3B1b916aDfE93F66e
reusing "SafeMigration" at 0xf15f955E07824931BBCe6A4Dd10C6C0a29FCf0E7`

[nlordell]

Hmm, looks like contracts aren't deployed to the right address.

[Yolokos]

Hmm, looks like contracts aren't deployed to the right address.

Do you have advice on how to handle it? Maybe, commit hash where I could deploy at the correct addresses, or maybe I need to change something, because I have no idea.

[nlordell]

This worked for me:

$ git clone -b release/v1.4.1 https://github.com/safe-global/safe-smart-account.git
...
$ cd safe-smart-account
$ npm ci
...
$ PK="..." NODE_URL="..." npm run deploy-all custom
...

Using a local development node, the contracts end up at the right address:

deploying "SimulateTxAccessor" (tx: 0x034754fc527e792395b2836a0ff9ac9afd0c7d6823a8022d2cc8d89e327fdbb0)...: deployed at 0x3d4BA2E0884aa488718476ca2FB8Efc291A46199 with 237931 gas
deploying "SafeProxyFactory" (tx: 0xb078c9345970d251793aa5e1ba2ceaf216d8a31fd2b8e8d6d686e5c3e152eda1)...: deployed at 0x4e1DCf7AD4e460CfD30791CCC4F9c8a4f820ec67 with 712622 gas
deploying "TokenCallbackHandler" (tx: 0x518956b3356d4bac93c6863438f3663918b394828dc8132cce717605859d976f)...: deployed at 0xeDCF620325E82e3B9836eaaeFdc4283E99Dd7562 with 453406 gas
deploying "CompatibilityFallbackHandler" (tx: 0xdf263f48ce2c36f7c9a22a13fa1f0492f4c19fb46c359bfee2c40988111e1a02)...: deployed at 0xfd0732Dc9E303f09fCEf3a7388Ad10A83459Ec99 with 1270132 gas
deploying "CreateCall" (tx: 0x1f3b5efbe313975ee3b7512f3f9a11a8ce555c32beccaacd79017d3d4c64ad8b)...: deployed at 0x9b35Af71d77eaf8d7e40252370304687390A1A52 with 290470 gas
deploying "MultiSend" (tx: 0xab7a67482683979762e1832dbb55b449756944b3980dfe2bbc10afd5fd2cc7e6)...: deployed at 0x38869bf66a61cF6bDB996A6aE40D5853Fd43B526 with 190062 gas
deploying "MultiSendCallOnly" (tx: 0x5b49511fdd23d50269f34b0bf479bfec715cc3a4124993d07d4c9ffee4a4d895)...: deployed at 0x9641d764fc13c8B624c04430C7356C1C7C8102e2 with 142150 gas
deploying "SignMessageLib" (tx: 0xd5f0e18be1ed990a4d1c9125899c8f91ee2f7ed691e8fdc0d14f891dc79a61ed)...: deployed at 0xd53cd0aB83D845Ac265BE939c57F53AD838012c9 with 262417 gas
deploying "SafeToL2Setup" (tx: 0xdfd9a8356d4a90e801eeb9d299ff7b2eb285d6dc1c63bb4bc0d0f6327c885b54)...: deployed at 0xBD89A1CE4DDe368FFAB0eC35506eEcE0b1fFdc54 with 230863 gas
deploying "Safe" (tx: 0x293c91e6d6e5358019b8709d83dd8f0083e4bad31dd3c78dd719c19427456855)...: deployed at 0x41675C099F32341bf84BFc5382aF534df5C7461a with 5150072 gas
deploying "SafeL2" (tx: 0x8039880253378e77816b0e068ab0dbd24880e242796602aff6e835c1bd6de05a)...: deployed at 0x29fcB43b46531BcA003ddC8FCB67FFE91900C762 with 5332531 gas
deploying "SafeToL2Migration" (tx: 0x85ab3db174a57e8260187ae5933ba5f5a56c07e0c334497fbfdbc5fa94c8a508)...: deployed at 0xfF83F6335d8930cBad1c0D439A841f01888D9f69 with 1283078 gas
deploying "SafeMigration" (tx: 0x538bb1a445612fb5957bc182c1385c9b5fc66d345288995812e21c3629bc5c8c)...: deployed at 0x526643F69b81B008F46d95CD5ced5eC0edFFDaC6 with 512858 gas

[nlordell]

Maybe, commit hash where I could deploy at the correct addresses

The release/v1.4.1 points to the right commit hash.

[Yolokos]

Maybe, commit hash where I could deploy at the correct addresses

The release/v1.4.1 points to the right commit hash.

Thank you, bro, for your advice on cloning the repo by version works for me too. Now, I have such addresses.

> @safe-global/[email protected] deploy-all
> hardhat deploy-contracts --network custom

Nothing to compile
No need to generate any newer typings.
deploying "SimulateTxAccessor" (tx: 0x0b9cfd0bab641267b45a5d845fbce126ee15562a0330f0b97ce690c2a4f61711)...: deployed at 0x3d4BA2E0884aa488718476ca2FB8Efc291A46199 with 237931 gas
deploying "SafeProxyFactory" (tx: 0x8168554184e31af4acad1b6df90405b8dd8b1ed02d6aff88f54cd0dc1a7236dd)...: deployed at 0x4e1DCf7AD4e460CfD30791CCC4F9c8a4f820ec67 with 712622 gas
deploying "TokenCallbackHandler" (tx: 0x3a027e64a21886e187d8e059cb2389c8e92d904a578c5f22c2af2a9b4880f31d)...: deployed at 0xeDCF620325E82e3B9836eaaeFdc4283E99Dd7562 with 453406 gas
deploying "CompatibilityFallbackHandler" (tx: 0x5133256182bb24dfbacc4d9c01bd7f127ffdb372fbecac0a671e5024e904ebeb)...: deployed at 0xfd0732Dc9E303f09fCEf3a7388Ad10A83459Ec99 with 1270132 gas
deploying "CreateCall" (tx: 0xef48f556471661c977974112fd8d746cd3279c8d86474301b05bbfddec79daec)...: deployed at 0x9b35Af71d77eaf8d7e40252370304687390A1A52 with 290470 gas
deploying "MultiSend" (tx: 0x635d57c6ccb31d5182d134c9505da5e83da24e93844344ad595fa803c1141c98)...: deployed at 0x38869bf66a61cF6bDB996A6aE40D5853Fd43B526 with 190062 gas
deploying "MultiSendCallOnly" (tx: 0xa878c3b00a91286bfd4699db546d163f3812f0c0fe508ca5975e656584496991)...: deployed at 0x9641d764fc13c8B624c04430C7356C1C7C8102e2 with 142150 gas
deploying "SignMessageLib" (tx: 0xc2ca56e5f8d310510dadaf4d4e87a1bae714eb35fc3478ced53b61193db0298c)...: deployed at 0xd53cd0aB83D845Ac265BE939c57F53AD838012c9 with 262417 gas
deploying "SafeToL2Setup" (tx: 0xd8634386239845ba85be427a3b44bbf5c535ee059035e7482e709a7859ec38f4)...: deployed at 0xBD89A1CE4DDe368FFAB0eC35506eEcE0b1fFdc54 with 230863 gas
deploying "Safe" (tx: 0x79063587519df76287c71fb175a6accf2f950898cecac7e2046e7c0c71afe6a3)...: deployed at 0x41675C099F32341bf84BFc5382aF534df5C7461a with 5150072 gas
deploying "SafeL2" (tx: 0xce1b603870c6043d33cbc8ce81aba5a1616b42b215f13f0388857f8d295ba4b0)...: deployed at 0x29fcB43b46531BcA003ddC8FCB67FFE91900C762 with 5332531 gas
deploying "SafeToL2Migration" (tx: 0xa645794d742c92b122a6b15448734ec8ffc6061c255cb802eaac20af2c0f357a)...: deployed at 0xfF83F6335d8930cBad1c0D439A841f01888D9f69 with 1283078 gas
deploying "SafeMigration" (tx: 0x24891934f2a1332d6b521288d2ea2830e01f239e58e854498a67163dc0bf80dc)...: deployed at 0x526643F69b81B008F46d95CD5ced5eC0edFFDaC6 with 512858 gas

[nlordell]

Thank you, bro, for your advice on cloning the repo by version works for me too.

Out of curiosity, what were you doing before?

[Yolokos]

Thank you, bro, for your advice on cloning the repo by version works for me too.

Out of curiosity, what were you doing before?

I cloned the repo main branch and just switched to the other branches, that's all. I didn't clone using -b parameter.

[nlordell]

I cloned the repo main branch and just switched to the other branches

I suspect your repo was in a weird state then, because the only difference between my suggestion and what you were doing, is that I suggested starting from a fresh clone. It would have been equivalent to do:

git clone https://github.com/safe-global/safe-smart-account.git
cd safe-smart-account
git checkout release/v1.4.1
# continue with the same steps from here...