Skip to content

more code cleanup and pep 8 work #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

more code cleanup and pep 8 work #41

wants to merge 6 commits into from

Conversation

decantr
Copy link

@decantr decantr commented Oct 22, 2017

changes made

more work towards overall #3 goal

  • random digits method removed in favour of an inline randint call 1fa0619
  • renamed get_joke to getJoke so app.py works again 87e9519
  • getJoke started at index 1 meaning it would never return the first joke e6ff3da
  • removed the ascii encoding and decoding as utf-8 is already enforced 4187f26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@decantr