WIP: crosstalk-free GST #641
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature-crosstalk-free-gst
…c parent class of CrosstalkFreeExperimentDesign.
…imentdesign functions
…gates with implicit availability
… just raise an more informative error). Add a copy in PermutationOperator.pp_braiding_operators.
…ys compute model violation w.r.t. logl objective function, rather than whatever might have been used as the final objective function.
…s. These are hacky changes. A proper change would be to use try-catch if encountering linalg errors.
…functions only use idles with explicit target qubits, rather than implicit global idles
… explicitmodel.py. Update convert_members_inplace so it can handle failures of conversion when dealing with embedded ops.
… in matrixforwardsim.py.
|
Biggest changes: New files in pygsti
Heavily modified files in pygsti
Changes to tests
|
Comment on lines
+686
to
+691
| try: | ||
| _ = self.__getattribute__(k) | ||
| except AttributeError: | ||
| _ = self.__dict__.pop(k) | ||
| self.__dict__['_' + k] = v | ||
| _ = self.__getattribute__(k) |
There was a problem hiding this comment.
I remember making this change but I don't remember why. We should revert unless we have a good reason to keep as-is.
| @@ -185,7 +199,7 @@ def to_label(x): | |||
| """ | |||
| if isinstance(x, _Label): return x | |||
| # # do this manually when desired, as it "boxes" a circuit being inserted | |||
| #elif isinstance(x,Circuit): return x.to_circuit_label() | |||
| elif isinstance(x,Circuit): return x.to_label() | |||
There was a problem hiding this comment.
Neither Nick nor I remember making this change. The commented-out branch was broken. The uncommenting seems valid based on the to_label member function of Circuit objects.
… to a static method" This reverts commit 8226079.
nkoskelo
commented
Aug 19, 2025
pygsti/layouts/matrixlayout.py
Outdated
There was a problem hiding this comment.
This is a new layout class to work with the new caching method implemented in pygsti.layouts.evaltree.
nkoskelo
commented
Aug 19, 2025
pygsti/circuits/circuitlist.py
Outdated
There was a problem hiding this comment.
Tensor circuit construction should retain knowledge of original lane structure.
nkoskelo
commented
Aug 19, 2025
| @@ -531,11 +547,13 @@ def _bare_init(self, labels, line_labels, editable, name='', stringrep=None, occ | |||
| self._name = name # can be None | |||
| #self._times = None # for FUTURE expansion | |||
| self.auxinfo = {} # for FUTURE expansion / user metadata | |||
| self.saved_auxinfo = {} | |||
| self.saved_auxinfo["lanes"] = {tuple(line_labels): self._labels} | |||
There was a problem hiding this comment.
We are saving off the lane structure here so that it can be used in the future if the error models are cross-talk free.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Add description.