Small changes #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent application to be default for some other schemes than said existing association, but said application can handle said association
…ram name that needs to be clicked to do an annoying relayout
This was referenced Jan 3, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes at least one bug: if Dolphin is configured to open inode/directory and I tell Gwenview to open a bunch of crap but not inode/directorys, setting Gwenview for other things would erase Dolphin's entry for inode/directory.
Adds search functionality and restricting of elements to a particular mimegroup; but made the leftmost view a ListView rather than a TreeView, so that you can tell what is there much easier.
Adds a right panel where you can see which associations (if any) an application already has in mimeapps.list.
Adds a help button for people who don't understand exactly what the application does.
Adds command-line option parsing but only one switch, to make it print much more verbose information to the command line.
Adds many comments to the code and makes the code more consistent. Use clang-format to format code, with a similar configuration to the Linux Kernel.
Only allows you to press Set as default once in a row for a QoL improvement and to give feedback that the button was pressed.
Removes a lot of unneccessary data structures from widget.cpp; now all the previous state is contained in one variable. This lets us remove some complexity in some areas. Unfortunately added a few more data structures which needed to store some other information for some of the new features, though, so it isn't actually simpler as a whole.
Oh, btw, now it is called selectdefaultapplication.cpp and not generic widget.cpp.
That's probably it but I might have forgotten something.