feat: [WIP] personalization schema #10859

pedrobonamin · 2025-10-17T09:04:07Z

Description

What to review

Testing

Notes for release

vercel · 2025-10-17T09:04:14Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
page-building-studio	Ready	Preview	Comment	Oct 21, 2025 8:19am
performance-studio	Ready	Preview	Comment	Oct 21, 2025 8:19am
test-studio	Ready	Preview	Comment	Oct 21, 2025 8:19am

3 Skipped Deployments

Project	Deployment	Preview	Updated (UTC)
e2e-studio	Ignored		Oct 21, 2025 8:19am
studio-workshop	Ignored	Preview	Oct 21, 2025 8:19am
test-next-studio	Ignored		Oct 21, 2025 8:19am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

github-actions · 2025-10-21T08:12:16Z

🧪 E2E Preview environment

🔑 Environment Variables for Local Testing

This is the preview URL for the E2E tests: https://e2e-studio-nq91mckzt.sanity.dev

To run the E2E tests locally, you can use the following environment variables, then run pnpm test:e2e --ui to open the Playwright test runner.

💬 Remember to build the project first with pnpm build:e2e.

  SANITY_E2E_PROJECT_ID=ittbm412
  SANITY_E2E_BASE_URL=https://e2e-studio-nq91mckzt.sanity.dev
  SANITY_E2E_DATASET="update depending the project you want to test (pr-10859-chromium-18677321882 || pr-10859-firefox-18677321882 )"
  SANITY_E2E_DATASET_CHROMIUM=pr-10859-chromium-18677321882
  SANITY_E2E_DATASET_FIREFOX=pr-10859-firefox-18677321882

github-actions · 2025-10-21T08:12:18Z

📊 Playwright Test Report

Download Full E2E Report

This report contains test results, including videos of failing tests.

github-actions · 2025-10-21T08:12:19Z

No changes to documentation

github-actions · 2025-10-21T08:17:43Z

⚡️ Editor Performance Report

Updated Tue, 21 Oct 2025 08:34:32 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	12.6 efps (80ms)	12.8 efps (78ms)	-2ms (-1.9%)	✅
article (body)	40.4 efps (25ms)	38.7 efps (26ms)	+1ms (+4.4%)	✅
article (string inside object)	13.6 efps (74ms)	12.9 efps (78ms)	+4ms (+5.4%)	✅
article (string inside array)	12.0 efps (83ms)	11.0 efps (91ms)	+8ms (+9.6%)	✅
recipe (name)	19.2 efps (52ms)	18.3 efps (55ms)	+3ms (+4.8%)	✅
recipe (description)	21.1 efps (48ms)	21.1 efps (48ms)	+0ms (-/-%)	✅
recipe (instructions)	99.9+ efps (10ms)	99.9+ efps (8ms)	-2ms (-/-%)	✅
singleString (stringField)	33.3 efps (30ms)	32.3 efps (31ms)	+1ms (+3.3%)	✅
synthetic (title)	8.0 efps (125ms)	8.2 efps (122ms)	-3ms (-2.0%)	✅
synthetic (string inside object)	10.1 efps (100ms)	10.3 efps (98ms)	-2ms (-2.0%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	80ms	110ms	148ms	258ms	2626ms	16.4s
article (body)	25ms	48ms	138ms	298ms	929ms	8.6s
article (string inside object)	74ms	89ms	106ms	171ms	2412ms	11.4s
article (string inside array)	83ms	110ms	140ms	411ms	2919ms	12.7s
recipe (name)	52ms	63ms	91ms	123ms	976ms	12.3s
recipe (description)	48ms	65ms	83ms	150ms	772ms	8.3s
recipe (instructions)	10ms	11ms	12ms	28ms	3ms	3.3s
singleString (stringField)	30ms	36ms	51ms	74ms	42ms	9.0s
synthetic (title)	125ms	151ms	210ms	461ms	5756ms	25.7s
synthetic (string inside object)	100ms	122ms	217ms	373ms	4141ms	14.1s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	78ms	91ms	123ms	284ms	2495ms	16.3s
article (body)	26ms	43ms	79ms	328ms	888ms	9.0s
article (string inside object)	78ms	103ms	130ms	366ms	2879ms	12.3s
article (string inside array)	91ms	108ms	134ms	216ms	2591ms	12.1s
recipe (name)	55ms	73ms	101ms	131ms	961ms	11.6s
recipe (description)	48ms	62ms	97ms	139ms	925ms	8.5s
recipe (instructions)	8ms	12ms	24ms	113ms	117ms	3.9s
singleString (stringField)	31ms	38ms	48ms	102ms	49ms	8.9s
synthetic (title)	122ms	168ms	217ms	359ms	5492ms	24.8s
synthetic (string inside object)	98ms	120ms	241ms	365ms	3944ms	13.3s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

github-actions · 2025-10-21T08:22:26Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	44.8%	64059 / 142965
🔵	Statements	44.8%	64059 / 142965
🔵	Functions	49.89%	3230 / 6473
🔵	Branches	79.3%	11961 / 15082

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/sanity/src/core/comments/utils/buildCommentThreadItems.ts	6.77%	100%	0%	6.77%	33-114
packages/sanity/src/core/config/configPropertyReducers.ts	56.2%	72.09%	80%	56.2%	55-60, 66-71, 123-131, 140-148, 157-162, 168-179, 185-196, 205-213, 222-231, 241-249, 262-268, 282-290, 299-313, 319-331, 337-360, 377-381, 398-402, 421-424, 429-435, 454-458, 475-481, 498-504, 521-523, 543, 562-568, 594-595, 632-637, 668-672, 686-687, 690-691, 694-695
packages/sanity/src/core/config/types.ts	100%	100%	100%	100%

Generated in workflow #43778 for commit 93c7a61 by the Vitest Coverage Report Action

vercel bot deployed to Preview – performance-studio October 17, 2025 09:04 View deployment

vercel bot deployed to Preview – test-studio October 17, 2025 09:06 View deployment

vercel bot temporarily deployed to Preview – page-building-studio October 17, 2025 12:06 Inactive

vercel bot deployed to Preview – performance-studio October 17, 2025 12:07 View deployment

vercel bot deployed to Preview – test-studio October 17, 2025 12:09 View deployment

pedrobonamin added 8 commits October 21, 2025 10:10

feat: wip implementation for user configurable conditions

972ce90

feat: add user configurable decision inputs

47b96f8

feat(dev): update decide schema UI

47001f4

feat(dev): add _type to decide objects

4ca05fe

chore: rename conditions to variants

fdfc7a1

fix: update decide schema types, copy from sanity/client

16c2643

feat(dev): add expressions schema to decide

a15ef39

feat: add function expression to the builder

93c7a61

pedrobonamin force-pushed the decide-schema-expressions branch from 3579fef to 93c7a61 Compare October 21, 2025 08:11

vercel bot deployed to Preview – page-building-studio October 21, 2025 08:17 View deployment

vercel bot deployed to Preview – performance-studio October 21, 2025 08:17 View deployment

vercel bot deployed to Preview – test-studio October 21, 2025 08:19 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: [WIP] personalization schema #10859

feat: [WIP] personalization schema #10859

Uh oh!

pedrobonamin commented Oct 17, 2025

Uh oh!

vercel bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 21, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 21, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 21, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 21, 2025 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

Uh oh!

github-actions bot commented Oct 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

feat: [WIP] personalization schema #10859

Are you sure you want to change the base?

feat: [WIP] personalization schema #10859

Uh oh!

Conversation

pedrobonamin commented Oct 17, 2025

Description

What to review

Testing

Notes for release

Uh oh!

vercel bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 E2E Preview environment

Uh oh!

github-actions bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Playwright Test Report

Uh oh!

github-actions bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

Uh oh!

github-actions bot commented Oct 21, 2025

Coverage Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel bot commented Oct 17, 2025 •

edited

Loading

github-actions bot commented Oct 21, 2025 •

edited

Loading

github-actions bot commented Oct 21, 2025 •

edited

Loading

github-actions bot commented Oct 21, 2025 •

edited

Loading

github-actions bot commented Oct 21, 2025 •

edited

Loading