refactor: support controlled focus path #10866

bjoerge · 2025-10-20T13:54:22Z

Description

What to review

Testing

Notes for release

vercel · 2025-10-20T13:54:30Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
page-building-studio	Ready	Preview	Comment	Oct 21, 2025 1:46pm
performance-studio	Ready	Preview		Oct 21, 2025 1:46pm
test-studio	Ready	Preview	Comment	Oct 21, 2025 1:46pm

3 Skipped Deployments

Project	Deployment	Preview	Updated (UTC)
e2e-studio	Ignored		Oct 21, 2025 1:46pm
studio-workshop	Ignored	Preview	Oct 21, 2025 1:46pm
test-next-studio	Ignored		Oct 21, 2025 1:46pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

github-actions · 2025-10-20T13:54:50Z

🧪 E2E Preview environment

🔑 Environment Variables for Local Testing

This is the preview URL for the E2E tests: https://e2e-studio-gofug932y.sanity.dev

To run the E2E tests locally, you can use the following environment variables, then run pnpm test:e2e --ui to open the Playwright test runner.

💬 Remember to build the project first with pnpm build:e2e.

  SANITY_E2E_PROJECT_ID=ittbm412
  SANITY_E2E_BASE_URL=https://e2e-studio-gofug932y.sanity.dev
  SANITY_E2E_DATASET="update depending the project you want to test (pr-10866-chromium-18685680750 || pr-10866-firefox-18685680750 )"
  SANITY_E2E_DATASET_CHROMIUM=pr-10866-chromium-18685680750
  SANITY_E2E_DATASET_FIREFOX=pr-10866-firefox-18685680750

github-actions · 2025-10-20T13:54:51Z

📊 Playwright Test Report

Download Full E2E Report

This report contains test results, including videos of failing tests.

github-actions · 2025-10-20T13:54:54Z

No changes to documentation

github-actions · 2025-10-20T14:10:30Z

Preview this PR with pkg.pr.new

Create a new project

npx https://pkg.pr.new/create-sanity@23db03f

Note: This installs the latest Sanity Studio from the npm registry. To apply the changes from this PR in your newly created project, run the install commands below for each package listed in your package.json

...Or run the Sanity CLI

npx https://pkg.pr.new/@sanity/cli@23db03f <command>

...Or upgrade project dependencies

Using pnpm

📦 `sanity`

pnpm install https://pkg.pr.new/sanity@3aec113

📦 `@sanity/vision`

pnpm install https://pkg.pr.new/@sanity/vision@3aec113

📦 Other packages…

📦 `create-sanity`

pnpm install https://pkg.pr.new/create-sanity@3aec113

📦 `groq`

pnpm install https://pkg.pr.new/groq@3aec113

📦 `@sanity/cli`

pnpm install https://pkg.pr.new/@sanity/cli@3aec113

📦 `@sanity/codegen`

pnpm install https://pkg.pr.new/@sanity/codegen@3aec113

📦 `@sanity/diff`

pnpm install https://pkg.pr.new/@sanity/diff@3aec113

📦 `@sanity/migrate`

pnpm install https://pkg.pr.new/@sanity/migrate@3aec113

📦 `@sanity/mutator`

pnpm install https://pkg.pr.new/@sanity/mutator@3aec113

📦 `@sanity/schema`

pnpm install https://pkg.pr.new/@sanity/schema@3aec113

📦 `@sanity/types`

pnpm install https://pkg.pr.new/@sanity/types@3aec113

📦 `@sanity/util`

pnpm install https://pkg.pr.new/@sanity/util@3aec113

Using npm

📦 `sanity`

npm install https://pkg.pr.new/sanity@3aec113

📦 `@sanity/vision`

npm install https://pkg.pr.new/@sanity/vision@3aec113

📦 Other packages…

📦 `create-sanity`

npm install https://pkg.pr.new/create-sanity@3aec113

📦 `groq`

npm install https://pkg.pr.new/groq@3aec113

📦 `@sanity/cli`

npm install https://pkg.pr.new/@sanity/cli@3aec113

📦 `@sanity/codegen`

npm install https://pkg.pr.new/@sanity/codegen@3aec113

📦 `@sanity/diff`

npm install https://pkg.pr.new/@sanity/diff@3aec113

📦 `@sanity/migrate`

npm install https://pkg.pr.new/@sanity/migrate@3aec113

📦 `@sanity/mutator`

npm install https://pkg.pr.new/@sanity/mutator@3aec113

📦 `@sanity/schema`

npm install https://pkg.pr.new/@sanity/schema@3aec113

📦 `@sanity/types`

npm install https://pkg.pr.new/@sanity/types@3aec113

📦 `@sanity/util`

npm install https://pkg.pr.new/@sanity/util@3aec113

View Commit (3aec113)

github-actions · 2025-10-20T14:11:22Z

⚡️ Editor Performance Report

Updated Tue, 21 Oct 2025 14:17:08 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	12.1 efps (83ms)	12.9 efps (78ms)	-5ms (-6.1%)	✅
article (body)	33.8 efps (30ms)	36.6 efps (27ms)	-2ms (-7.8%)	✅
article (string inside object)	14.5 efps (69ms)	13.1 efps (77ms)	+8ms (+10.9%)	✅
article (string inside array)	12.7 efps (79ms)	12.5 efps (80ms)	+2ms (+1.9%)	✅
recipe (name)	19.2 efps (52ms)	19.2 efps (52ms)	+0ms (-/-%)	✅
recipe (description)	20.6 efps (49ms)	20.8 efps (48ms)	-1ms (-1.0%)	✅
recipe (instructions)	99.9+ efps (8ms)	99.9+ efps (8ms)	+0ms (-/-%)	✅
singleString (stringField)	32.3 efps (31ms)	30.3 efps (33ms)	+2ms (+6.5%)	✅
synthetic (title)	8.7 efps (115ms)	8.4 efps (119ms)	+4ms (+3.5%)	✅
synthetic (string inside object)	9.9 efps (101ms)	10.0 efps (101ms)	-1ms (-0.5%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	83ms	121ms	210ms	445ms	3262ms	17.7s
article (body)	30ms	42ms	149ms	503ms	1182ms	9.3s
article (string inside object)	69ms	92ms	130ms	387ms	2370ms	11.6s
article (string inside array)	79ms	97ms	158ms	357ms	2780ms	12.1s
recipe (name)	52ms	69ms	93ms	156ms	970ms	11.6s
recipe (description)	49ms	67ms	80ms	129ms	716ms	8.3s
recipe (instructions)	8ms	10ms	13ms	80ms	68ms	3.4s
singleString (stringField)	31ms	36ms	54ms	118ms	102ms	9.5s
synthetic (title)	115ms	182ms	319ms	453ms	5810ms	25.5s
synthetic (string inside object)	101ms	133ms	236ms	453ms	4608ms	14.9s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	78ms	125ms	220ms	379ms	2904ms	17.5s
article (body)	27ms	65ms	115ms	307ms	789ms	8.9s
article (string inside object)	77ms	100ms	120ms	308ms	2429ms	11.7s
article (string inside array)	80ms	102ms	175ms	386ms	2796ms	12.3s
recipe (name)	52ms	69ms	83ms	191ms	1262ms	12.2s
recipe (description)	48ms	62ms	80ms	131ms	751ms	8.5s
recipe (instructions)	8ms	10ms	14ms	62ms	4ms	3.3s
singleString (stringField)	33ms	42ms	62ms	95ms	134ms	8.9s
synthetic (title)	119ms	191ms	259ms	394ms	5960ms	23.8s
synthetic (string inside object)	101ms	134ms	206ms	342ms	4044ms	14.2s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

github-actions · 2025-10-20T14:16:50Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	44.79%	64063 / 143017
🔵	Statements	44.79%	64063 / 143017
🔵	Functions	49.87%	3231 / 6478
🔵	Branches	79.31%	11965 / 15085

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/sanity/src/core/form/useDocumentForm.ts	8.78%	100%	0%	8.78%	131-535
packages/sanity/src/core/form/useFormLocation.ts	4.65%	100%	0%	4.65%	13-64, 73-120
packages/sanity/src/core/tasks/components/form/tasksFormBuilder/TasksFormBuilder.tsx	19.13%	100%	0%	19.13%	27-35, 49-128, 136-186
packages/sanity/src/presentation/PresentationContent.tsx	0%	100%	100%	0%	7-100
packages/sanity/src/presentation/PresentationTool.tsx	0%	100%	100%	0%	2-652
packages/sanity/src/presentation/editor/ContentEditor.tsx	0%	0%	0%	0%	1-161
packages/sanity/src/presentation/editor/DocumentPane.tsx	0%	0%	0%	0%	1-121
packages/sanity/src/presentation/editor/DocumentPanel.tsx	0%	100%	100%	0%	3-43
packages/sanity/src/structure/components/paneRouter/PaneRouterProvider.tsx	8.73%	100%	0%	8.73%	28-258
packages/sanity/src/structure/components/paneRouter/types.ts	0%	0%	0%	0%
packages/sanity/src/structure/diffView/components/DiffViewPane.tsx	7.65%	100%	0%	7.65%	68-143, 146-299
packages/sanity/src/structure/panes/document/DocumentPaneProvider.tsx	3.53%	100%	100%	3.53%	64-656
packages/sanity/src/structure/panes/document/types.ts	0%	0%	0%	0%

Generated in workflow #43839 for commit 3aec113 by the Vitest Coverage Report Action

bjoerge added the trigger: preview label Oct 20, 2025

bjoerge changed the title ~~wip: presentation focus issues~~ refactor: support controlled focus path Oct 20, 2025

vercel bot deployed to Preview – performance-studio October 20, 2025 14:12 View deployment

vercel bot deployed to Preview – page-building-studio October 20, 2025 14:13 View deployment

vercel bot deployed to Preview – test-studio October 20, 2025 14:13 View deployment

bjoerge added a commit to joneidejohnsen/sanity-visual-editing-demo that referenced this pull request Oct 20, 2025

fix: update to sanity-io/sanity#10866

3659d86

bjoerge force-pushed the fix-presentation-focus-issues branch from 7a7f742 to d26e9f4 Compare October 20, 2025 15:15

vercel bot deployed to Preview – page-building-studio October 20, 2025 15:22 View deployment

vercel bot deployed to Preview – performance-studio October 20, 2025 15:22 View deployment

vercel bot deployed to Preview – test-studio October 20, 2025 15:23 View deployment

bjoerge added a commit to joneidejohnsen/sanity-visual-editing-demo that referenced this pull request Oct 20, 2025

fix: update to latest sanity-io/sanity#10866

e16b038

bjoerge force-pushed the fix-presentation-focus-issues branch from d26e9f4 to 0d7c7dc Compare October 21, 2025 12:53

vercel bot deployed to Preview – performance-studio October 21, 2025 12:59 View deployment

vercel bot deployed to Preview – page-building-studio October 21, 2025 12:59 View deployment

vercel bot deployed to Preview – test-studio October 21, 2025 13:00 View deployment

bjoerge force-pushed the fix-presentation-focus-issues branch from 0d7c7dc to b131cfc Compare October 21, 2025 13:18

vercel bot deployed to Preview – performance-studio October 21, 2025 13:25 View deployment

vercel bot deployed to Preview – test-studio October 21, 2025 13:26 View deployment

vercel bot deployed to Preview – page-building-studio October 21, 2025 13:27 View deployment

stipsan and others added 4 commits October 21, 2025 15:35

refactor: enhance stega debugging

133b369

fix(test-studio): move heavyweight visual editing example second

eac9e98

fix(presentation): hoist focus path handling to top

c4c2679

refactor: add support for controlled focus handling

8f398d0

bjoerge added 3 commits October 21, 2025 15:35

fix: maintain local focus path in tasks form builder

6531b05

fix: maintain local focus state in diff view pane (needs verification)

260a4e7

chore: fix lint error

3aec113

bjoerge force-pushed the fix-presentation-focus-issues branch from 601beb0 to 3aec113 Compare October 21, 2025 13:35

vercel bot deployed to Preview – test-studio October 21, 2025 13:43 View deployment

vercel bot deployed to Preview – page-building-studio October 21, 2025 13:45 View deployment

vercel bot deployed to Preview – performance-studio October 21, 2025 13:46 View deployment

bjoerge mentioned this pull request Oct 24, 2025

refactor: add counter on the nested object header + url navigation within modals #10800

Merged

refactor: support controlled focus path #10866

Are you sure you want to change the base?

refactor: support controlled focus path #10866

Uh oh!

Conversation

bjoerge commented Oct 20, 2025

Description

What to review

Testing

Notes for release

Uh oh!

vercel bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 E2E Preview environment

Uh oh!

github-actions bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Playwright Test Report

Uh oh!

github-actions bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview this PR with pkg.pr.new

Create a new project

...Or run the Sanity CLI

...Or upgrade project dependencies

Using pnpm

📦 sanity

📦 @sanity/vision

📦 create-sanity

📦 groq

📦 @sanity/cli

📦 @sanity/codegen

📦 @sanity/diff

📦 @sanity/migrate

📦 @sanity/mutator

📦 @sanity/schema

📦 @sanity/types

📦 @sanity/util

Using npm

📦 sanity

📦 @sanity/vision

📦 create-sanity

📦 groq

📦 @sanity/cli

📦 @sanity/codegen

📦 @sanity/diff

📦 @sanity/migrate

📦 @sanity/mutator

📦 @sanity/schema

📦 @sanity/types

📦 @sanity/util

Uh oh!

github-actions bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

Uh oh!

github-actions bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Oct 20, 2025 •

edited

Loading

github-actions bot commented Oct 20, 2025 •

edited

Loading

github-actions bot commented Oct 20, 2025 •

edited

Loading

github-actions bot commented Oct 20, 2025 •

edited

Loading

github-actions bot commented Oct 20, 2025 •

edited

Loading

📦 `sanity`

📦 `@sanity/vision`

📦 `create-sanity`

📦 `groq`

📦 `@sanity/cli`

📦 `@sanity/codegen`

📦 `@sanity/diff`

📦 `@sanity/migrate`

📦 `@sanity/mutator`

📦 `@sanity/schema`

📦 `@sanity/types`

📦 `@sanity/util`

📦 `sanity`

📦 `@sanity/vision`

📦 `create-sanity`

📦 `groq`

📦 `@sanity/cli`

📦 `@sanity/codegen`

📦 `@sanity/diff`

📦 `@sanity/migrate`

📦 `@sanity/mutator`

📦 `@sanity/schema`

📦 `@sanity/types`

📦 `@sanity/util`

github-actions bot commented Oct 20, 2025 •

edited

Loading

github-actions bot commented Oct 20, 2025 •

edited

Loading