refactor(sanity): validate that there is no callbacks in aspects

packages/@sanity/schema/src/sanity/validateMediaLibraryAssetAspect.ts

@@ -2,6 +2,7 @@ import {type SchemaValidationProblem} from '@sanity/types'
 
 import {groupProblems} from './groupProblems'
 import {validateSchema} from './validateSchema'
+import {validateNoCallbacks} from './validation/utils/validateNoCallbacks'
 
 function unsupportedTypeValidator(typeLabel: string) {
   return function () {
@@ -16,6 +17,13 @@ function unsupportedTypeValidator(typeLabel: string) {
   }
 }
 
+function noCallbacksVisitor(typeDef: any, visitorContext: any) {
+  return {
+    ...typeDef,
+    _problems: validateNoCallbacks(typeDef),
+  }
+}
+
 /**
  * Ensure that the provided value is a valid Media Library asset aspect that can be safely deployed.
  *
@@ -27,6 +35,7 @@ export function validateMediaLibraryAssetAspect(
   const input = [maybeAspect]
 
   const validated = validateSchema(input, {
+    transformCommonVisitors: (visitors) => [...visitors, noCallbacksVisitor],
     transformTypeVisitors: (typeVisitors) => ({
       ...typeVisitors,
       document: unsupportedTypeValidator('document'),

packages/@sanity/schema/src/sanity/validateSchema.ts

@@ -49,14 +49,18 @@ function combine(...visitors: any) {
 
 interface Options {
   transformTypeVisitors?: (visitors: typeof typeVisitors) => Partial<typeof typeVisitors>
+  transformCommonVisitors?: (visitors: any[]) => any[]
 }
 
 /**
  * @internal
  */
 export function validateSchema(
   schemaTypes: _FIXME_,
-  {transformTypeVisitors = (visitors) => visitors}: Options = {},
+  {
+    transformTypeVisitors = (visitors) => visitors,
+    transformCommonVisitors = (visitors) => visitors,
+  }: Options = {},
 ) {
   return traverseSanitySchema(schemaTypes, (schemaDef, visitorContext) => {
     const typeVisitor =
@@ -65,10 +69,13 @@ export function validateSchema(
         (transformTypeVisitors(typeVisitors) as any)[schemaDef.type]) ||
       getNoopVisitor(visitorContext)
 
+    // Transform common visitors for extensibility
+    const commonVisitors = transformCommonVisitors([common])
+
     if (visitorContext.isRoot) {
-      return combine(rootType, common, typeVisitor)(schemaDef, visitorContext)
+      return combine(rootType, ...commonVisitors, typeVisitor)(schemaDef, visitorContext)
     }
 
-    return combine(common, typeVisitor)(schemaDef, visitorContext)
+    return combine(...commonVisitors, typeVisitor)(schemaDef, visitorContext)
   })
 }