expose & fix scalameta deprecations WIP #1744
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
changed the title
bjaglin
force-pushed
the
scalameta-deprecations
branch
from
3209234 to
a8500fe
Compare
bjaglin
force-pushed
the
scalameta-deprecations
branch
from
a8500fe to
5e77b05
Compare
bjaglin
force-pushed
the
scalameta-deprecations
branch
from
5e77b05 to
0501523
Compare
bjaglin
force-pushed
the
scalameta-deprecations
branch
from
33845a5 to
289971f
Compare
bjaglin
force-pushed
the
scalameta-deprecations
branch
from
289971f to
498b375
Compare
bjaglin
commented
Jun 3, 2023
|
|
||
| ```scala | ||
| case Term.Apply(_, args) => | ||
| case Term.Apply.After_4_6_0(_, args) => |
There was a problem hiding this comment.
git history for https://github.com/scalacenter/scalafix-named-literal-arguments should be rewritten
kitbellew
reviewed
Jun 1, 2025
| } | ||
| .getOrElse { | ||
| Ctor.Primary(Nil, Name(""), Seq.empty[Term.ParamClause]) | ||
| Ctor.Primary.After_4_6_0( |
There was a problem hiding this comment.
i thought specific versions were only needed for unapply
There was a problem hiding this comment.
Good catch, I didn't even remember an apply was created for the specific versions. I guess I just changed that because of a bad search, but there is no reason to. In any case, this PR needs so much rebase that I would (will?) probably start from scratch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.