Skip to content

Conversation

ikrommyd
Copy link
Collaborator

Fixes #3663

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.66%. Comparing base (b749e49) to head (cdb105b).
⚠️ Report is 432 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
src/awkward/contents/emptyarray.py 76.47% <100.00%> (+0.84%) ⬆️

... and 196 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3664

Copy link
Collaborator

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikrommyd - thanks for looking into it! I wonder if it's better to do a lazy iteration instead of a list comprehension. Thanks.

@ikrommyd
Copy link
Collaborator Author

@ikrommyd - thanks for looking into it! I wonder if it's better to do a lazy iteration instead of a list comprehension. Thanks.

What lazy iteration did you think about? others is already a list in memory and I'm just trying to drop the empty array elements. What do you have in mind?

@ikrommyd ikrommyd requested a review from ianna October 1, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concatenating arrays with EmptyArray in the layout hits the python recursion limit
2 participants