Skip to content

Conversation

wlemmon
Copy link

@wlemmon wlemmon commented Jul 12, 2025

i fixed the thing

bmwoodruff

This comment was marked as outdated.

raise OSError('decimals should be an integer!')

hours_num = angle_in_degrees*24/180
hours_num = angle_in_degrees*24/360

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would spaces between operators help with readability here? What are the style rules for this repo?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attended BYU myself

Copy link

@tomato-gits tomato-gits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got a test failure
________________________________________ test_angle_to_sexigesimal_360 _________________________________________

def test_angle_to_sexigesimal_360():
    """Simplest test for one crete case"""
  assert angle_to_sexigesimal(360.0) == '24:0:0.000'

E AssertionError: assert '48:0:0.000' == '24:0:0.000'
E
E - 24:0:0.000
E ? -
E + 48:0:0.000
E ? +

pr_tutorial/tests/test_buggy_function.py:6: AssertionError

________________________________________ test_angle_to_sexigesimal_360 _________________________________________

def test_angle_to_sexigesimal_360():
    """Simplest test for one crete case"""
  assert angle_to_sexigesimal(360.0) == '24:0:0.000'

E AssertionError: assert '48:0:0.000' == '24:0:0.000'
E
E - 24:0:0.000
E ? -
E + 48:0:0.000
E ? +

pr_tutorial/tests/test_buggy_function.py:6: AssertionError

@wlemmon
Copy link
Author

wlemmon commented Jul 12, 2025

got a test failure ________________________________________ test_angle_to_sexigesimal_360 _________________________________________

def test_angle_to_sexigesimal_360():
    """Simplest test for one crete case"""
  assert angle_to_sexigesimal(360.0) == '24:0:0.000'

E AssertionError: assert '48:0:0.000' == '24:0:0.000' E E - 24:0:0.000 E ? - E + 48:0:0.000 E ? +

pr_tutorial/tests/test_buggy_function.py:6: AssertionError

________________________________________ test_angle_to_sexigesimal_360 _________________________________________

def test_angle_to_sexigesimal_360():
    """Simplest test for one crete case"""
  assert angle_to_sexigesimal(360.0) == '24:0:0.000'

E AssertionError: assert '48:0:0.000' == '24:0:0.000' E E - 24:0:0.000 E ? - E + 48:0:0.000 E ? +

pr_tutorial/tests/test_buggy_function.py:6: AssertionError

Did you re "pip install ." at the package root?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants