-
Notifications
You must be signed in to change notification settings - Fork 18
fix buggy function. #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
raise OSError('decimals should be an integer!') | ||
|
||
hours_num = angle_in_degrees*24/180 | ||
hours_num = angle_in_degrees*24/360 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would spaces between operators help with readability here? What are the style rules for this repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attended BYU myself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got a test failure
________________________________________ test_angle_to_sexigesimal_360 _________________________________________
def test_angle_to_sexigesimal_360():
"""Simplest test for one crete case"""
assert angle_to_sexigesimal(360.0) == '24:0:0.000'
E AssertionError: assert '48:0:0.000' == '24:0:0.000'
E
E - 24:0:0.000
E ? -
E + 48:0:0.000
E ? +
pr_tutorial/tests/test_buggy_function.py:6: AssertionError
________________________________________ test_angle_to_sexigesimal_360 _________________________________________
def test_angle_to_sexigesimal_360():
"""Simplest test for one crete case"""
assert angle_to_sexigesimal(360.0) == '24:0:0.000'
E AssertionError: assert '48:0:0.000' == '24:0:0.000'
E
E - 24:0:0.000
E ? -
E + 48:0:0.000
E ? +
pr_tutorial/tests/test_buggy_function.py:6: AssertionError
Did you re "pip install ." at the package root? |
i fixed the thing