install.sh create .sdkman/libexec if missing. #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierre-rouleau
commented
Sep 30, 2025
pierre-rouleau
commented
- The script was not creating the missing directory.
- I also added printing the name of the directory where files were copied. New users (like me) may want to know where files went.
* The script was not creating the missing directory. * I also added printing the name of the directory where files were copied. New users (like me) may want to know where files went.
Member
|
Hi, the sdkman installer script already creates and populates the directory with binaries so this shouldn't be necessary if your SDKMAN is up to date. Can you share what version of SDKMAN you have on your machine? |
Author
|
I have: script: 5.20.0 native: 0.7.14 (macos aarch64) However, I was under the impression that I did not need to have the original SDKMAN installed. However performing the extra checks as I added in the script are either required or the assumption about the existing presence should be identified somewhere to make it clear. No? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.