FIX: Remove download on error #1290
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,7 +32,7 @@ function __sdkman_secure_curl() { | |||
|
|
|||
| function __sdkman_secure_curl_download() { | |||
| local curl_params | |||
| curl_params=('--progress-bar' '--location') | |||
| curl_params=('--progress-bar' '--location' '--remove-on-error') | |||
There was a problem hiding this comment.
Hi! I would actually challenge my own suggestion 😄! While that would work for newer versions of curl, it may break on older versions, no?
There was a problem hiding this comment.
Ah, and it shows 😆
curl: option --remove-on-error: is unknown
|
I think a much more portable solution would to be to perform the cleanup in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.