Improved logging in collaborator module #1627
Conversation
…ation. Refactor the `run` method to include detailed error logging and a new `_execute_collaborator_rounds` method for better task management. Update the `start_` function to handle exceptions during collaborator initialization and execution, ensuring critical errors are logged and communicated to the user. Additionally, improve type hints and docstrings for better code clarity and maintainability. Signed-off-by: Rahul Garg <[email protected]>
…rmatting of log messages. This change enhances the clarity of critical error messages and maintains a uniform style across the logging functionality. Signed-off-by: Rahul Garg <[email protected]>
rahulga1
requested review from
MasterSkepticista,
kminhta,
psfoley,
teoparvanov,
aayushgaintel,
theakshaypant,
gbikkiintel,
pasokan-intel,
rajithkrishnegowda,
tanwarsh and
srikanthenugul
as code owners
rahulga1
changed the title
|
Run once PQ as well. It has ellaborated set of tests. |
There was a problem hiding this comment.
Please hold off on merging this until #1575 is merged, as that PR introduces significant changes to the collaborator code. Merging this now will likely cause substantial merge conflicts and may require an overwrite.
Additionally, do we know if this PR addresses the silent crashes, or at a minimum, provides relevant evidence?
Sure Karan, will wait for the other PR to merge, I have seen the benefit of this which helped me to debug the mnist pipeline failure which was happening due to my change. Anyways I will share again the screenshot after updated PR to show the usability of it. |
|
@teoparvanov @MasterSkepticista in the meantime, I will appreciate if you have other feedback about the changes, which I can take care of. |
Summary
Enhance error handling in Collaborator module.
Type of Change (Mandatory)
Specify the type of change being made.
Description (Mandatory)
Enhance error handling in Collaborator module. Added try-except blocks to manage exceptions during the execution of collaborator rounds and while starting the collaborator service. Critical errors are now logged, and appropriate messages are displayed to the user, ensuring smoother operation and clearer feedback in case of failures.
Testing
Local Testing