Skip to content

Conversation

@signekb
Copy link
Member

@signekb signekb commented Oct 22, 2025

Description

This PR adds a combined C4 component/code diagram for the core Python package. It kind of mirrors the existing flow diagram in the interface docs. I initially made a more detailed version trying to mirror the implementation more closely, but for the purpose of this, I think this might be fine with this level of detail.

Related to #46

Needs an in-depth review.

Checklist

  • Formatted Markdown
  • Ran just run-all

Only including a diagram for the core Python package, not one for the future CLI.
@signekb signekb moved this from Todo to In Review in Iteration planning Oct 22, 2025
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Only one change needed

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Oct 27, 2025
@signekb signekb requested a review from lwjohnst86 October 27, 2025 10:13
@signekb signekb moved this from In Progress to In Review in Iteration planning Oct 27, 2025
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😁

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Oct 27, 2025
@lwjohnst86 lwjohnst86 merged commit 0008ff5 into main Oct 27, 2025
6 checks passed
@lwjohnst86 lwjohnst86 deleted the docs/c4-component-code-diagram branch October 27, 2025 10:42
@github-project-automation github-project-automation bot moved this from In Progress to Done in Iteration planning Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants