-
Notifications
You must be signed in to change notification settings - Fork 55
2312 change text in sample type buttons #2314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The study tables should say 'Study sources' and 'Study samples'
The text should reflect the assay title instead of the sample type title
- Logic to hide columns in the dynamic table has been rewritten - ID fields are hidden in experiment view by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the display text for sample type buttons in ISA studies and assays to show more descriptive labels. Instead of showing just the sample type title, the buttons now display study/assay names with descriptive suffixes like "- sources" and "- samples".
- Modified study table to use study title with "sources/samples" suffixes for sample type buttons
- Updated assay table to display assay titles instead of sample type titles
- Enhanced dynamic table helper to include assay title information and improved attribute handling
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
app/views/isa_studies/_study_table.html.erb | Updated sample type button text to show study title with "sources/samples" suffixes |
app/views/isa_assays/_assay_table.html.erb | Modified to display assay title instead of sample type title in buttons |
app/helpers/dynamic_table_helper.rb | Added assay_title to sample types data and improved attribute type handling |
app/assets/javascripts/single_page/dynamic_table.js.erb | Updated attribute type checking and column visibility logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Closes #2312