Skip to content

Conversation

kdp-cloud
Copy link
Collaborator

Closes #2312

The study tables should say 'Study sources' and 'Study samples'
The text should reflect the assay title instead of the sample type title
- Logic to hide columns in the dynamic table has been rewritten
- ID fields are hidden in experiment view by default
@kdp-cloud kdp-cloud added this to the 1.17.1 milestone Sep 1, 2025
@kdp-cloud kdp-cloud requested a review from Copilot September 1, 2025 13:17
@kdp-cloud kdp-cloud self-assigned this Sep 1, 2025
@kdp-cloud kdp-cloud added enhancement datahub belgiumHub project labels Sep 1, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the display text for sample type buttons in ISA studies and assays to show more descriptive labels. Instead of showing just the sample type title, the buttons now display study/assay names with descriptive suffixes like "- sources" and "- samples".

  • Modified study table to use study title with "sources/samples" suffixes for sample type buttons
  • Updated assay table to display assay titles instead of sample type titles
  • Enhanced dynamic table helper to include assay title information and improved attribute handling

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
app/views/isa_studies/_study_table.html.erb Updated sample type button text to show study title with "sources/samples" suffixes
app/views/isa_assays/_assay_table.html.erb Modified to display assay title instead of sample type title in buttons
app/helpers/dynamic_table_helper.rb Added assay_title to sample types data and improved attribute type handling
app/assets/javascripts/single_page/dynamic_table.js.erb Updated attribute type checking and column visibility logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kdp-cloud
Copy link
Collaborator Author

kdp-cloud commented Sep 1, 2025

The buttons in the experiment view now show:

  • At study level: 'Study title + sources' or 'study title + samples'
image
  • At assay level: Assay title
image

@kdp-cloud kdp-cloud marked this pull request as ready for review September 1, 2025 14:34
@kdp-cloud kdp-cloud linked an issue Sep 10, 2025 that may be closed by this pull request
@kdp-cloud kdp-cloud moved this to In review in SEEK 1.17.x Sep 10, 2025
@kdp-cloud kdp-cloud moved this to Coded in DataHub Sep 10, 2025
@kdp-cloud kdp-cloud merged commit 9dbaffc into seek-1.17 Sep 16, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in SEEK 1.17.x Sep 16, 2025
@github-project-automation github-project-automation bot moved this from In review to Merged in DataHub Sep 16, 2025
@kdp-cloud kdp-cloud deleted the 2312-change-text-in-sample-type-buttons branch September 16, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datahub belgiumHub project enhancement
Projects
Status: Merged
Status: Done
Development

Successfully merging this pull request may close these issues.

Change text in sample type buttons
2 participants