Skip to content

Conversation

kdp-cloud
Copy link
Collaborator

@kdp-cloud kdp-cloud linked an issue Sep 10, 2025 that may be closed by this pull request
@kdp-cloud kdp-cloud self-assigned this Sep 10, 2025
@kdp-cloud kdp-cloud changed the base branch from main to seek-1.17 September 10, 2025 10:29
@kdp-cloud kdp-cloud added bug datahub belgiumHub project labels Sep 10, 2025
@kdp-cloud kdp-cloud moved this to Coded in DataHub Sep 10, 2025
@kdp-cloud kdp-cloud moved this to In review in SEEK 1.17.x Sep 10, 2025
@kdp-cloud kdp-cloud added this to the 1.17.1 milestone Sep 10, 2025
@kdp-cloud kdp-cloud requested a review from Copilot September 10, 2025 11:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where default permissions were not being inherited at the ISA study level by updating the project selector implementation.

  • Moves the implicit project selector to the end of the form and updates its configuration
  • Removes the sample type presence check for assay stream design button
  • Adjusts the select_id parameter to match the updated field structure

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
app/views/studies/_buttons.html.erb Removes conditional check for sample types when displaying assay stream design button
app/views/isa_studies/_form.html.erb Relocates implicit project selector to end of form with updated configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kdp-cloud kdp-cloud marked this pull request as ready for review September 10, 2025 11:09
@kdp-cloud kdp-cloud merged commit 7f73c82 into seek-1.17 Sep 16, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in SEEK 1.17.x Sep 16, 2025
@github-project-automation github-project-automation bot moved this from In review to Merged in DataHub Sep 16, 2025
@kdp-cloud kdp-cloud deleted the 2321-default-permissions-not-inherited-at-isa-study-level branch September 16, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug datahub belgiumHub project
Projects
Status: Merged
Status: Done
Development

Successfully merging this pull request may close these issues.

Default permissions not inherited at ISA study level
2 participants