Skip to content

Conversation

kdp-cloud
Copy link
Collaborator

@kdp-cloud kdp-cloud commented Sep 10, 2025

Tooltip id restored when hovering the header cell in the dynamic table.
image

Closes #2324

@kdp-cloud kdp-cloud requested a review from Copilot September 10, 2025 14:05
@kdp-cloud kdp-cloud self-assigned this Sep 10, 2025
@kdp-cloud kdp-cloud added the bug label Sep 10, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes tooltip functionality issues in the dynamic table by centralizing tooltip initialization and ensuring proper cleanup. The changes ensure tooltip ids are correctly restored when hovering over header cells.

  • Moves tooltip initialization to the draw callback to ensure tooltips are properly reset on each table redraw
  • Removes redundant tooltip attributes and initialization from the existing setupTable method
  • Implements proper tooltip cleanup using destroy before re-initialization

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kdp-cloud kdp-cloud added this to the 1.17.1 milestone Sep 10, 2025
@kdp-cloud kdp-cloud moved this to Coded in DataHub Sep 10, 2025
@kdp-cloud kdp-cloud moved this to In review in SEEK 1.17.x Sep 10, 2025
@kdp-cloud kdp-cloud marked this pull request as ready for review September 10, 2025 14:09
@kdp-cloud kdp-cloud linked an issue Sep 10, 2025 that may be closed by this pull request
@kdp-cloud kdp-cloud added the datahub belgiumHub project label Sep 10, 2025
@kdp-cloud kdp-cloud merged commit 977b2a3 into seek-1.17 Sep 16, 2025
19 checks passed
@kdp-cloud kdp-cloud deleted the 2324-cannot-see-attribute-header-description-in-dt-when-hovering-over branch September 16, 2025 09:11
@github-project-automation github-project-automation bot moved this from In review to Merged in DataHub Sep 16, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in SEEK 1.17.x Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug datahub belgiumHub project
Projects
Status: Merged
Status: Done
Development

Successfully merging this pull request may close these issues.

Cannot see attribute header description in DT when hovering over
2 participants