Skip to content

Conversation

kdp-cloud
Copy link
Collaborator

Closes #2323

image

@kdp-cloud kdp-cloud added this to the 1.17.1 milestone Sep 10, 2025
@kdp-cloud kdp-cloud requested a review from Copilot September 10, 2025 14:23
@kdp-cloud kdp-cloud self-assigned this Sep 10, 2025
@kdp-cloud kdp-cloud added the datahub belgiumHub project label Sep 10, 2025
@kdp-cloud kdp-cloud linked an issue Sep 10, 2025 that may be closed by this pull request
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the "Paste From Clipboard" functionality from the ISA studies interface. The primary purpose is to eliminate the clipboard pasting feature that allowed users to paste data from their clipboard into data tables.

Key changes:

  • Removal of clipboard paste button from the UI
  • Deletion of associated JavaScript functionality for clipboard operations
  • Addition of timezone testing helpers and comprehensive date formatting tests

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
app/views/isa_studies/_buttons.html.erb Removes the "Paste From Clipboard" button and associated help text from the UI
app/assets/javascripts/single_page/dynamic_table.js.erb Removes the pasteFromClipboard JavaScript function and related clipboard handling logic
app/helpers/application_helper.rb Refactors date formatting logic to reduce duplication and improve maintainability
test/test_helper.rb Adds timezone helper method for testing date formatting across different timezones
test/unit/helpers/application_helper_test.rb Adds comprehensive tests for date formatting with timezone support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kdp-cloud kdp-cloud changed the base branch from main to seek-1.17 September 10, 2025 14:24
@kdp-cloud kdp-cloud moved this to In review in DataHub Sep 10, 2025
@kdp-cloud kdp-cloud moved this to In review in SEEK 1.17.x Sep 10, 2025
@kdp-cloud kdp-cloud marked this pull request as ready for review September 10, 2025 14:51
@kdp-cloud kdp-cloud merged commit ba68332 into seek-1.17 Sep 16, 2025
19 checks passed
@kdp-cloud kdp-cloud deleted the 2323-delete-paste-from-clipboard-from-dt branch September 16, 2025 09:12
@github-project-automation github-project-automation bot moved this from In review to Done in SEEK 1.17.x Sep 16, 2025
@github-project-automation github-project-automation bot moved this from In review to Merged in DataHub Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datahub belgiumHub project
Projects
Status: Merged
Status: Done
Development

Successfully merging this pull request may close these issues.

Delete Paste From Clipboard from DT
2 participants