Skip to content

Conversation

aaronmell
Copy link

No description provided.

@seesharper
Copy link
Owner

Hi Aaron.
I really appreciate the effort to improve LightInject.Mvc.

I will probably accept this pull request although I will wait until the the next version of LightInject is ready.
We are currently doing an iOS/Android version.

Next I need to have tests for this as well as the build system for LightInject does not allow anything to be published unless we have 100% coverage. This might seem a little restrictive, but this rule has served me well :)

Finally we need to update the documentation for LightInject.Mvc so that users can see how to use this feature in their projects.

Best regards
Bernhard Richter

@aaronmell
Copy link
Author

I don't mind writing some unit tests. I actually planned to do that, I'll
update my pull request with the inclusion of some tests.

On Wed, Jul 16, 2014 at 9:12 AM, Bernhard Richter [email protected]
wrote:

Hi Aaron.
I really appreciate the effort to improve LightInject.Mvc.

I will probably accept this pull request although I will wait until the
the next version of LightInject is ready.
We are currently doing an iOS/Android version.

Next I need to have tests for this as well as the build system for
LightInject does not allow anything to be published unless we have 100%
coverage. This might seem a little restrictive, but this rule has served me
well :)

Finally we need to update the documentation for LightInject.Mvc so that
users can see how to use this feature in their projects.

Best regards
Bernhard Richter


Reply to this email directly or view it on GitHub
#93 (comment).

@seesharper
Copy link
Owner

Great!!

Again, I really appreciate your contribution

Best regards
Bernhard Richter

@Nelo-cool
Copy link

Guys? Work or not?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants