Skip to content

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Jun 26, 2025

  • Removed #if DEBUG requirement for relaying signals to segment.
  • Added sendDebugSignalsToSegment to signals config, defaults to false.
  • Added obfuscateDebugSignals to signals config, defaults to true.
  • Added tests & internal test infra.

New dev setup to effectively create event generators in the Segment UI would be something like this ...

let signalsConfig = SignalsConfiguration(
            writeKey: "signals_test2",
#if DEBUG
            sendDebugSignalsToSegment: true, // send signals to segment.
            obfuscateDebugSignals: false // don't obfuscate symbols
#endif
        )
Signals.shared.useConfiguration(signalsConfig)

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 29.68%. Comparing base (3b381b2) to head (7fcb61a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...Live/Signals/Broadcasters/SegmentBroadcaster.swift 80.00% 3 Missing ⚠️
Sources/AnalyticsLive/Signals/Configuration.swift 93.75% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (29.68%) is below the target coverage (50.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #27       +/-   ##
===========================================
+ Coverage   18.81%   29.68%   +10.87%     
===========================================
  Files          37       37               
  Lines        3040     3055       +15     
===========================================
+ Hits          572      907      +335     
+ Misses       2468     2148      -320     
Files with missing lines Coverage Δ
...alyticsLive/Signals/Minilytics/MiniAnalytics.swift 43.22% <100.00%> (+43.22%) ⬆️
Sources/AnalyticsLive/Signals/Signals.swift 62.56% <100.00%> (+62.56%) ⬆️
.../AnalyticsLive/Signals/Utilities/Obfuscation.swift 78.12% <ø> (+75.09%) ⬆️
Sources/AnalyticsLive/Signals/Configuration.swift 93.93% <93.75%> (+93.93%) ⬆️
...Live/Signals/Broadcasters/SegmentBroadcaster.swift 78.26% <80.00%> (+78.26%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bsneed bsneed merged commit 7c3ffca into main Jun 27, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants