No longer prompt user for local network access on app launch on macOS Sequoia #1065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Calling ProcessInfo.processInfo.hostName causes a new TCC prompt on macOS Sequoia for the user requesting the app be granted local network access. This code path is hit pretty often, typically during app launch. However, nothing in this framework inherently requires local network access, thus by changing the property to "unknown" instead, any app linking this framework will no longer be forced to prompt for local network access.
Where should the reviewer start?
Simple change
How should this be manually tested?
Test with an app on macOS Sequoia
Any background context you want to provide?
This is similar to segmentio/analytics-swift#363
What are the relevant tickets?
N/A
Screenshots or screencasts (if UI/UX change)
Questions:
Does the docs need an update?
No
Are there any security concerns?
Yes without this the user is prompted with privacy dialogs unnecessarily and maybe spooked out by an app unwittingly requesting for the permission when it may not require it.
Do we need to update engineering / success?
No