feat: survey variable for multi select #3351
Open
+303
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackb1rd
force-pushed
the
feat/multi-select
branch
2 times, most recently
from
fb24124 to
0e0369d
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for multi-select survey variables to Semaphore UI templates. The feature introduces a new "select" variable type that allows users to choose multiple values from a predefined list, building upon the existing "enum" type which only allows single selection.
Key changes:
- Added new "select" survey variable type with multi-select capabilities
- Extended frontend components to handle array-based values for select types
- Implemented custom JSON marshaling/unmarshaling to support both single and multiple default values
- Added UI components for managing multi-select variables with chips and deletion functionality
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| web/src/lang/en.js | Added localization string for "Allow multiple values" feature |
| web/src/components/TeamMenu.vue | Removed extra whitespace (formatting cleanup) |
| web/src/components/TaskParamsForm.vue | Enhanced form to support select type variables with multi-select UI, array normalization, and chip-based selection display |
| web/src/components/TaskForm.vue | Added multi-select support to task creation form with chip display and item deletion |
| web/src/components/SurveyVars.vue | Extended survey variable editor to support select type with multi-select default values and proper array/string normalization |
| db/Template.go | Introduced SurveyVarSelect constant and custom SurveyVarDefaultValue type with flexible JSON marshaling for single/multiple values |
blackb1rd
force-pushed
the
feat/multi-select
branch
from
6c58c9c to
51846ce
Compare
|
Let me test new code change and I will let you know. |
|
It looks like everything is working. I'll test it in production next week to check for any issues. |
blackb1rd
force-pushed
the
feat/multi-select
branch
from
3d86963 to
41b5824
Compare
blackb1rd
commented
Oct 14, 2025
…mplate and TaskForm components Signed-off-by: blackb1rd <[email protected]>
…lt value normalization and selection chips Signed-off-by: blackb1rd <[email protected]>
…ct type Signed-off-by: blackb1rd <[email protected]>
…s component Signed-off-by: blackb1rd <[email protected]>
…urveyVar Signed-off-by: blackb1rd <[email protected]>
… improved default value normalization Signed-off-by: Prachya Saechua <[email protected]>
…m for default value normalization Signed-off-by: Prachya Saechua <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…in TaskParamsForm.vue Signed-off-by: blackb1rd <[email protected]>
Signed-off-by: blackb1rd <[email protected]>
…in TaskParamsForm.vue Signed-off-by: Prachya Saechua <[email protected]>
…ability Signed-off-by: Prachya Saechua <[email protected]>
…ndling of survey variables Signed-off-by: Prachya Saechua <[email protected]>
…hing logic in TaskParamsForm.vue Signed-off-by: Prachya Saechua <[email protected]>
Signed-off-by: Prachya Saechua <[email protected]>
…ring undefined values and merging defaults into edited environment Signed-off-by: Prachya Saechua <[email protected]>
…veyVarType JSON handling Signed-off-by: Prachya Saechua <[email protected]>
…rm.vue Signed-off-by: Prachya Saechua <[email protected]>
…l errors Signed-off-by: Prachya Saechua <[email protected]>
…ion and improve default variable handling in TaskParamsForm.vue Signed-off-by: Prachya Saechua <[email protected]>
…Environment in TaskParamsForm.vue Signed-off-by: Prachya Saechua <[email protected]>
Signed-off-by: Prachya Saechua <[email protected]>
blackb1rd
force-pushed
the
feat/multi-select
branch
from
894c9b2 to
8a657a7
Compare
Co-authored-by: Copilot <[email protected]>
Signed-off-by: blackb1rd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebase #2754 and change naming multi_enum to select
Closes #2751