Unify error handling to have IpcError and TryRecvError be the main errortypes. #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narfinger
force-pushed
the
error-handling
branch
2 times, most recently
from
a9f4457 to
3f0752a
Compare
Narfinger
changed the title
Narfinger
force-pushed
the
error-handling
branch
4 times, most recently
from
fae67df to
4ef7ae4
Compare
|
Ok the async errors should be fixed now. Please rerun the CI to see if there is anything else missing. |
sagudev
reviewed
Aug 6, 2025
Narfinger
force-pushed
the
error-handling
branch
2 times, most recently
from
512913c to
d606cd9
Compare
Narfinger
force-pushed
the
error-handling
branch
from
d606cd9 to
9d20d5e
Compare
|
What's the status here, given that you closed #408? If we do not plan to change serialization library I wish to avoid landing any breaking changes at least in short term. |
|
I still want to change serialization libraries but adding the benchmark comes first. I noticed that bitcode did not provide any improvements for the performance but postcard seems to be good. |
Narfinger
force-pushed
the
error-handling
branch
from
9d20d5e to
44bd4ff
Compare
types. These types will give the Bincode error, Io errors (which are converted from platform errors) and Disconnect. Additionally we now use the thiserror crate which removes some of the code. Signed-off-by: Narfinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These types will give the Bincode error, Io errors (which are converted
from platform errors) and Disconnect.
Additionally we now use the thiserror crate which removes some of the
code.
This is a breaking change but because there are others comming we do not increase the version yet.