Skip to content

Conversation

mrehayden1
Copy link
Contributor

@mrehayden1 mrehayden1 commented Nov 6, 2024

Just rolling back a few version numbers to support GHC 9.2.

Tests are passing with the latest ghc 9.2 lts snapshot, which I've added in a new stack config file.

Currently doing my own testing in a new project I've started.

@sgillespie
Copy link
Owner

Why not jump to 9.6?

@mrehayden1
Copy link
Contributor Author

I've got some dependencies that won't install on 9.6 yet.

microlens-platform ^>=0.4.3,
linear ^>=1.21,
microlens ^>=0.4.12,
microlens-platform ^>=0.4.2,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a problem with any of this, but maybe it would be better to use proper ranges? eg, `linear >= 1.21 && <1.23

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood the meaning of ^>=.

Yes, I think we would need to expand that out to support 1.21 to 1.23

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having had a bit more time, I think we should leave microlens, microlens-platform as you have done there. For linear, let's make it 1.21 && <2, since it seems to mostly use the minor version component

@sgillespie sgillespie merged commit a85d8be into sgillespie:main Nov 18, 2024
1 check failed
@sgillespie
Copy link
Owner

Thanks! I went ahead and updated linear as I mentioned earlier, and all the builds are succeeding now. Let me know how your testing goes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants