This repository was archived by the owner on Apr 29, 2021. It is now read-only.
Having a way to find multiple refs. Fixes #22 #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if(refs.length == 1) | ||
| return findWithRefForOne(root, refs[0]); | ||
|
|
||
| return refs.map(ref => findWithRefForOne(root, ref)); |
There was a problem hiding this comment.
We could optimize this by changing the findAll function to take in multiple options so that it does the tree traversal only once. But if we need this just for findWithRef those changes would seem unnecessary
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22
We could extend this to other functions as well, but I didn't find the need to do it (yet).