dns server is mandatory while configuring ip in grub

[henkjan]

Not adding a dns server in the ip= config part in grub while configuring a static ip adress results in a configuration error and talos booting with dhcp instead of the static ip adress.

[smira]

What is the failure you were getting? I can't reproduce the problem with the config as it was before your change

[smira]

diff --git a/internal/app/machined/pkg/controllers/network/cmdline_test.go b/internal/app/machined/pkg/controllers/network/cmdline_test.go
index 01827499c..9db5fe7bf 100644
--- a/internal/app/machined/pkg/controllers/network/cmdline_test.go
+++ b/internal/app/machined/pkg/controllers/network/cmdline_test.go
@@ -557,6 +557,26 @@ func TestCmdlineParse(t *testing.T) {
                        cmdline:       "vlan=eth1.0:eth1",
                        expectedError: fmt.Sprintf("invalid vlanID=%d, must be in the range 1..4095: %s", 0, "eth1.0:eth1"),
                },
+               {
+                       name:    "another ip configuration",
+                       cmdline: "ip=192.168.0.100::192.168.0.1:255.255.255.0::eth0:off",
+                       expectedSettings: network.CmdlineNetworking{
+                               LinkConfigs: []network.CmdlineLinkConfig{
+                                       {
+                                               LinkName: "eth0",
+                                               Address:  netip.MustParsePrefix("192.168.0.100/24"),
+                                               Gateway:  netip.MustParseAddr("192.168.0.1"),
+                                       },
+                               },
+                               NetworkLinkSpecs: []netconfig.LinkSpecSpec{
+                                       {
+                                               Name:        "eth0",
+                                               Up:          true,
+                                               ConfigLayer: netconfig.ConfigCmdline,
+                                       },
+                               },
+                       },
+               },
                {
                        name:    "multiple ip configurations",
                        cmdline: "ip=172.20.0.2::172.20.0.1:255.255.255.0::eth1::::: ip=eth3:dhcp ip=:::::eth4:dhcp::::",

this patch works without issues

[github-actions]

This PR is stale because it has been open 45 days with no activity.