RFC 3261 Compliance: Preserve sip: Prefix in RPID for Polycom User-Ag… #2942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents This change restores RFC 3261 compliance for Remote-Party-ID header construction. Previously, when the User-Agent string contained “Poly” or “Polycom,” FreeSWITCH intentionally omitted the sip: prefix in the RPID <addr-spec> to accommodate legacy Polycom firmware display issues. Those early devices would incorrectly render the full SIP URI on-screen. Modern Poly/Polycom firmware has resolved this behavior. To ensure proper interoperability with RFC-compliant SBCs (e.g., Sansay VSXi, Ribbon, BroadWorks) and strict SIP stacks, we now always include the sip: prefix in the RPID while retaining all other Polycom-specific logic and formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change restores RFC 3261 compliance for Remote-Party-ID header construction.
Previously, when the User-Agent string contained “Poly” or “Polycom,” FreeSWITCH intentionally omitted the sip: prefix in the RPID to accommodate legacy Polycom firmware display issues. Those early devices would incorrectly render the full SIP URI on-screen.
Modern Poly/Polycom firmware has resolved this behavior. To ensure proper interoperability with RFC-compliant SBCs (e.g., Sansay VSXi, Ribbon, BroadWorks) and strict SIP stacks, we now always include the sip: prefix in the RPID while retaining all other Polycom-specific logic and formatting.