More proposer shuffling cleanup #8130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
commented
Sep 29, 2025
michaelsproul
commented
Sep 29, 2025
dapplion
reviewed
Oct 10, 2025
michaelsproul
added
ready-for-review
Member
Author
|
Tests updated and ready for re-review. I would like to get this in for v8.0.0-rc.2, as it fixes some bugs and should improve performance. |
jimmygchen
reviewed
Oct 17, 2025
jimmygchen
reviewed
Oct 17, 2025
jimmygchen
requested changes
Oct 17, 2025
Member
jimmygchen
left a comment
jimmygchen
left a comment
There was a problem hiding this comment.
Looks good to me, I couldn't spot any issues, just some minor comments in test.
jimmygchen
added
waiting-on-author
michaelsproul
added
ready-for-review
1 task
Member
Author
|
I've opened a follow-up PR here, but I don't think it's necessary for correctness, so leaving it out of v8.0.0(-rc.2): |
jimmygchen
added
ready-for-merge
6 tasks
jchavarri
pushed a commit
to jchavarri/lighthouse
that referenced
this pull request
Oct 21, 2025
Addressing more review comments from: - sigp#8101 I've also tweaked a few more things that I think are minor bugs. - Instrument `ensure_state_can_determine_proposers_for_epoch` - Fix `block_root` usage in `compute_proposer_duties_from_head`. This was a regression introduced in 8101 😬 . - Update the `state_advance_timer` to prime the next-epoch proposer cache post-Fulu. Co-Authored-By: Michael Sproul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Addressing more review comments from:
I've also tweaked a few more things that I think are minor bugs.
Proposed Changes
ensure_state_can_determine_proposers_for_epochblock_rootusage incompute_proposer_duties_from_head. This was a regression introduced in 8101 😬 .state_advance_timerto prime the next-epoch proposer cache post-Fulu.Additional Info
proposer_duties_from_head_fuluand I have confirmed it fails when reverting the usage ofproposer_shuffling_decision_root_at_epochwith the correct block root.try_proposer_duties_from_cache. Seeproposer_duties_with_gossip_tolerance.