Persist only custody columns in db #8188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
reviewed
Oct 10, 2025
| let columns_to_custody = self.custody_columns_for_epoch(Some( | ||
| block_slot.epoch(T::EthSpec::slots_per_epoch()), | ||
| )); | ||
| // Supernodes need to persist all sampled custody columns |
There was a problem hiding this comment.
Suggested change
| // Supernodes need to persist all sampled custody columns | |
| // If `columns_to_custody` contains all possible custody groups, no need to filter |
I would update in the comment the mention of supernode. In the future, nodes custodying >50% of columns and doing reconstruction may be supernodes?
There was a problem hiding this comment.
I think this is fine, supernode is explicitly defined here in the spec
https://github.com/ethereum/consensus-specs/blob/dev/specs/fulu/p2p-interface.md#supernodes
dapplion
reviewed
Oct 10, 2025
dapplion
reviewed
Oct 10, 2025
dapplion
reviewed
Oct 10, 2025
dapplion
reviewed
Oct 10, 2025
dapplion
reviewed
Oct 10, 2025
dapplion
reviewed
Oct 10, 2025
jimmygchen
added
backwards-incompat
jimmygchen
reviewed
Oct 13, 2025
jimmygchen
added a commit
to jimmygchen/lighthouse
that referenced
this pull request
Oct 13, 2025
commit aa64356 Author: Pawan Dhananjay <[email protected]> Date: Fri Oct 10 15:30:45 2025 -0700 lint commit 9fab592 Author: Pawan Dhananjay <[email protected]> Date: Fri Oct 10 15:10:05 2025 -0700 Get claude to write tests commit bd181a3 Author: Pawan Dhananjay <[email protected]> Date: Fri Oct 10 13:34:41 2025 -0700 Only persist custody columns
jimmygchen
added
ready-for-review
michaelsproul
approved these changes
Oct 13, 2025
|
Some required checks have failed. Could you please take a look @pawanjay176? 🙏 |
mergify
bot
added
waiting-on-author
jimmygchen
reviewed
Oct 13, 2025
michaelsproul
added
ready-for-merge
6 tasks
jchavarri
pushed a commit
to jchavarri/lighthouse
that referenced
this pull request
Oct 21, 2025
* Only persist custody columns * Get claude to write tests * lint * Address review comments and fix tests. * Use supernode only when building chain segments * Clean up * Rewrite tests. * Fix tests * Clippy --------- Co-authored-by: Jimmy Chen <[email protected]> Co-authored-by: Michael Sproul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Resolves #8129
Proposed Changes
Persist only the custody columns and not sampling columns like before.