Skip to content

Conversation

jimmygchen
Copy link
Member

Issue Addressed

Addresses this comment: #8254 (comment)

We're currently using subscribe_all_data_column_subnets here to subscribe to all subnets

if fork_name.fulu_enabled() {
if opts.subscribe_all_data_column_subnets {
for i in 0..spec.data_column_sidecar_subnet_count {
topics.push(GossipKind::DataColumnSidecar(i.into()));
}
} else {
for subnet in &opts.sampling_subnets {
topics.push(GossipKind::DataColumnSidecar(*subnet));
}
}
}

But its unnecessary because the else path also works for supernode (uses sampling_subnets instead)

The big diffs will disappear once #8254 is merged.

@jimmygchen jimmygchen requested a review from jxs as a code owner October 22, 2025 01:06
@jimmygchen jimmygchen added code-quality ready-for-review The code is ready for review v8.1.0 Post-Fulu release labels Oct 22, 2025
@jimmygchen jimmygchen force-pushed the semi-supernode-simple-cleanup branch from f3a3e2a to 029ba13 Compare October 23, 2025 05:10
@mergify
Copy link

mergify bot commented Oct 23, 2025

Some required checks have failed. Could you please take a look @jimmygchen? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality v8.1.0 Post-Fulu release waiting-on-author The reviewer has suggested changes and awaits thier implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant