Trigger backfill on startup if user switches to a supernode or semi-supernode #8265

jimmygchen · 2025-10-22T06:44:23Z

Issue Addressed

This PR adds backfill functionality to nodes switching to become a supernode or semi-supernode. Please note that we currently only support a CGC increase, i.e. if the node's already custodying 67 columns, switching to semi-supernode (64) will have no effect.

Proposed changes

From @eserilev

if a node's cgc increases on start up, we just need two things for custody backfill to do its thing

data column custody info needs to be updated to reflect the cgc change

CustodyContext::validator_registrations::epoch_validator_custody_requirements needs to be updated to reflect the cgc change

beacon_node/beacon_chain/src/custody_context.rs

…upernode (#8265) Squashed commit of the following: commit 8cedbd1 Author: Jimmy Chen <[email protected]> Date: Thu Oct 23 00:20:17 2025 +1100 Remove unnecessary changes to reduce diff. commit 13cef6d Author: Jimmy Chen <[email protected]> Date: Thu Oct 23 00:10:54 2025 +1100 Minor clean ups. commit 045afbb Author: Jimmy Chen <[email protected]> Date: Wed Oct 22 23:59:01 2025 +1100 Clean up and update function docs. commit 6904556 Author: Jimmy Chen <[email protected]> Date: Wed Oct 22 23:51:17 2025 +1100 Add column backfill when node's custody type changes via CLI. commit 895e571 Author: Jimmy Chen <[email protected]> Date: Wed Oct 22 17:39:55 2025 +1100 Add tests and TODOs

beacon_node/beacon_chain/src/custody_context.rs

mergify · 2025-10-22T14:34:51Z

Some required checks have failed. Could you please take a look @jimmygchen? 🙏

beacon_node/beacon_chain/src/builder.rs

beacon_node/beacon_chain/src/custody_context.rs

eserilev · 2025-10-22T20:13:52Z

This all looks pretty good to me. I have a devnet3 node running right now and am about to finish backfilling. Will test this out shortly

eserilev

I got this working on a local devnet 3 node

The node was first started as a normal full node (cgc = 4). I then let it finish backfilling and restarted the node as a semi super node. It's now been doing custody backfill for the last hour (I still have like 4-5 hours to go). But seems like the triggering of custody backfill worked as intended. Nice work!

I think Pawan is right that we could use the current head epoch instead of the current slot clock epoch, but seems like this would probably work either way.

The tests seem pretty good too, I'd like to piggy back off those tests in this PR

pawanjay176

LGTM other than the calculation of current_epoch.
The tests are great, I have also tested the same manually.

pawanjay176 · 2025-10-22T19:21:19Z

beacon_node/beacon_chain/src/custody_context.rs

-    ///   and will require a resync until we implement column backfill for this scenario.
+    /// # Behavior
+    /// * If [`NodeCustodyType::get_custody_count_override`] < validator_custody_at_head, it means the attached
+    ///   validator stake has increased the node's CGC. We ignore the CLI input.


This comment is a little unclear. Maybe something along the lines of

/// the node has a higher contribution of custody from the number of validators attached compared to the one derived from cli flags

Something a little less verbose than that though :P

Updated to

/// * If [`NodeCustodyType::get_custody_count_override`] < validator_custody_at_head, it means /// validators have increased the CGC beyond the derived CGC from cli flags. We ignore the CLI input.

… apply other comment fixes.

eserilev

changes look good

…upernode (#8265) Squashed commit of the following: commit 2ed4f69 Author: Jimmy Chen <[email protected]> Date: Thu Oct 23 10:56:42 2025 +1100 Change CLI CGC increase effective epoch to be based on head_epoch and apply other comment fixes. commit 8cedbd1 Author: Jimmy Chen <[email protected]> Date: Thu Oct 23 00:20:17 2025 +1100 Remove unnecessary changes to reduce diff. commit 13cef6d Author: Jimmy Chen <[email protected]> Date: Thu Oct 23 00:10:54 2025 +1100 Minor clean ups. commit 045afbb Author: Jimmy Chen <[email protected]> Date: Wed Oct 22 23:59:01 2025 +1100 Clean up and update function docs. commit 6904556 Author: Jimmy Chen <[email protected]> Date: Wed Oct 22 23:51:17 2025 +1100 Add column backfill when node's custody type changes via CLI. commit 895e571 Author: Jimmy Chen <[email protected]> Date: Wed Oct 22 17:39:55 2025 +1100 Add tests and TODOs

pawanjay176

LGTM

Open PRs to include for the release - #7907 - #8247 - #8251 - #8253 - #8254 - #8265 - #8269 - #8266 Co-Authored-By: Jimmy Chen <[email protected]> Co-Authored-By: Jimmy Chen <[email protected]>

Add tests and TODOs

895e571

jimmygchen commented Oct 22, 2025

View reviewed changes

beacon_node/beacon_chain/src/custody_context.rs Outdated Show resolved Hide resolved

michaelsproul added the v8.0.0 Q4 2025 Fusaka Mainnet Release label Oct 22, 2025

jimmygchen added 4 commits October 22, 2025 23:51

Add column backfill when node's custody type changes via CLI.

6904556

Clean up and update function docs.

045afbb

Minor clean ups.

13cef6d

Remove unnecessary changes to reduce diff.

8cedbd1

jimmygchen force-pushed the backfill-column-supernode branch from 401b8d0 to 8cedbd1 Compare October 22, 2025 13:23

jimmygchen added the ready-for-review The code is ready for review label Oct 22, 2025

jimmygchen mentioned this pull request Oct 22, 2025

Release v8.0.0 rc.2 #8255

Merged

jimmygchen commented Oct 22, 2025

View reviewed changes

beacon_node/beacon_chain/src/custody_context.rs Show resolved Hide resolved

mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Oct 22, 2025

jimmygchen added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Oct 22, 2025

pawanjay176 reviewed Oct 22, 2025

View reviewed changes

beacon_node/beacon_chain/src/builder.rs Outdated Show resolved Hide resolved

eserilev reviewed Oct 22, 2025

View reviewed changes

beacon_node/beacon_chain/src/custody_context.rs Outdated Show resolved Hide resolved

beacon_node/beacon_chain/src/custody_context.rs Outdated Show resolved Hide resolved

eserilev approved these changes Oct 22, 2025

View reviewed changes

pawanjay176 reviewed Oct 22, 2025

View reviewed changes

jimmygchen mentioned this pull request Oct 22, 2025

v8.0.0 release testing checklist #8233

Open

7 tasks

Change CLI CGC increase effective epoch to be based on head_epoch and…

2ed4f69

… apply other comment fixes.

eserilev approved these changes Oct 23, 2025

View reviewed changes

pawanjay176 approved these changes Oct 23, 2025

View reviewed changes

jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Oct 23, 2025

mergify bot added the queued label Oct 23, 2025

mergify bot added a commit that referenced this pull request Oct 23, 2025

Merge of #8265

79fa79d

mergify bot mentioned this pull request Oct 23, 2025

merge queue: embarking unstable (43c5e92) and #8265 together #8272

Closed

6 tasks

mergify bot added a commit that referenced this pull request Oct 23, 2025

Merge of #8265

7767c77

mergify bot merged commit d8c6c57 into sigp:unstable Oct 23, 2025
37 checks passed

mergify bot removed the queued label Oct 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Trigger backfill on startup if user switches to a supernode or semi-supernode #8265

Trigger backfill on startup if user switches to a supernode or semi-supernode #8265

Uh oh!

jimmygchen commented Oct 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Oct 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eserilev commented Oct 22, 2025

Uh oh!

eserilev left a comment

Uh oh!

pawanjay176 left a comment

Uh oh!

pawanjay176 Oct 22, 2025

Uh oh!

jimmygchen Oct 22, 2025

Uh oh!

eserilev left a comment

Uh oh!

pawanjay176 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Trigger backfill on startup if user switches to a supernode or semi-supernode #8265

Trigger backfill on startup if user switches to a supernode or semi-supernode #8265

Uh oh!

Conversation

jimmygchen commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Addressed

Proposed changes

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Oct 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eserilev commented Oct 22, 2025

Uh oh!

eserilev left a comment

Choose a reason for hiding this comment

Uh oh!

pawanjay176 left a comment

Choose a reason for hiding this comment

Uh oh!

pawanjay176 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

jimmygchen Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

eserilev left a comment

Choose a reason for hiding this comment

Uh oh!

pawanjay176 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jimmygchen commented Oct 22, 2025 •

edited

Loading