cli: Add --rekor-version to sign arguments #1471
Merged
+58
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jku
force-pushed
the
add-rekor-version-option
branch
3 times, most recently
from
aa1cb9e to
a86bcf7
Compare
di
reviewed
Jul 22, 2025
jku
force-pushed
the
add-rekor-version-option
branch
from
a86bcf7 to
55c8911
Compare
|
I'm filing a separate issue about testing the bundle compatibility -- choosing the rekor version is one thing but there are other related changes in the bundle we produce (like TSA timestamps) that could affect compatibility |
This should not be needed... but it could be handy if * SigningConfig already contains rekor v2 * user for some reason does not want rekor v2 entries in the bundle This option only does anything if there are multiple Rekor versions listed in SigningConfig. The test is changed since the "ANY" selector is now considered to not be an error if there are 0 services: * This is not a problem since for both TSAs and tlogs we have a check that there is at least one service * This improves the error message when --rekor-version is used with a version that is not found in signingconfig Signed-off-by: Jussi Kukkonen <[email protected]>
Signed-off-by: Jussi Kukkonen <[email protected]>
Avoid saying "default: None", mention the valid values instead. Signed-off-by: Jussi Kukkonen <[email protected]>
jku
force-pushed
the
add-rekor-version-option
branch
from
55c8911 to
dc21376
Compare
|
I'm keeping this a draft until I'm confident I know how #1474 looks like |
This was referenced Jul 30, 2025
Closed
jku
force-pushed
the
add-rekor-version-option
branch
from
25be8c6 to
b36e65b
Compare
|
Marking ready for review: I'm still not sure if this is actually useful but happy to include (and improve) it if others feel like it's useful. sigstore-python 3.6.5 correctly verifies a signature bundle created with sigstore-python from this branch if |
woodruffw
approved these changes
Aug 25, 2025
I will merge as is for two reasons:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CLI option that should not be needed... but it could be handy if
This option only does anything if there are multiple Rekor versions listed in SigningConfig.
The test is changed since the "ANY" selector is now considered to not be
an error if there are 0 services:
that there is at least one service
a version that is not found in signingconfig