Use fetch to get images instead of axios (BL-14629) #119
Conversation
|
|
There was a problem hiding this comment.
One question, but otherwise looks good to me.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrew-polk)
src/images.ts line 155 at r1 (raw file):
// so we switched to fetch. Just a guess, but probably imgur keeps locking down // what it suspects as code running to scrape images. Apparently, imgur is getting // to be more and more of a liability, so we should probably stop using it.
Is the "particular gif" fetch no longer a problem or the "particular gif" no longer needed? Or is this fetch method different from the node-fetch mentioned in the comment?
andrew-polk
force-pushed
the
BL14629_Imgur429
branch
from
a61ce3a to
af56a19
Compare
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @StephenMcConnel)
src/images.ts line 155 at r1 (raw file):
Previously, StephenMcConnel (Steve McConnel) wrote…
Is the "particular gif" fetch no longer a problem or the "particular gif" no longer needed? Or is this fetch method different from the node-fetch mentioned in the comment?
Great question. They're different. I enhanced the comment.
There was a problem hiding this comment.
Dismissed @StephenMcConnel from a discussion.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @StephenMcConnel)
|
🎉 This PR is included in version 0.16.2-alpha.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.16.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This change is