Skip to content

Conversation

pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Oct 6, 2025

This PR updates dotnet dependencies, in particular:

  • ParatextData to 9.5.0.19 which removes the requirement to use DotNetZip, as well as the need to include specific dependency versions in the csproj file.
  • MongoDB.Driver to 3.5 (and associated Hangfire.Mongo update)
  • Updates the Paratext zip file test logic to use SharpZipLib
  • Bump the dotnet package versions to 8.0.20
  • Other minor package updates

I have marked this as not requiring testing, as a unit test pass and the usually weekly regression testing will be sufficient to test this.


This change is Reviewable

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.21%. Comparing base (000607b) to head (02c0cbe).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3493   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         615      615           
  Lines       37032    37032           
  Branches     6044     6063   +19     
=======================================
  Hits        30445    30445           
+ Misses       5703     5690   -13     
- Partials      884      897   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami added the e2e Run e2e tests for this pull request label Oct 6, 2025
@pmachapman pmachapman force-pushed the update/dotnet-dependencies branch from 8c81696 to 683d279 Compare October 12, 2025 23:19
@RaymondLuong3 RaymondLuong3 self-assigned this Oct 16, 2025
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@RaymondLuong3 reviewed 10 of 18 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@RaymondLuong3 RaymondLuong3 force-pushed the update/dotnet-dependencies branch from 683d279 to 02c0cbe Compare October 16, 2025 16:28
@RaymondLuong3 RaymondLuong3 merged commit 0b0bae6 into master Oct 16, 2025
22 of 23 checks passed
@RaymondLuong3 RaymondLuong3 deleted the update/dotnet-dependencies branch October 16, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run e2e tests for this pull request testing not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants