Skip to content

Conversation

marksvc
Copy link
Collaborator

@marksvc marksvc commented Oct 10, 2025

This change is Reviewable

@marksvc
Copy link
Collaborator Author

marksvc commented Oct 10, 2025

I sought to maintain the same file lengths, codecs, and test-audio-player.webm === test-audio-player-b.webm.

@marksvc
Copy link
Collaborator Author

marksvc commented Oct 10, 2025

This changes each audio sample to be silent.

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.29%. Comparing base (f4e173d) to head (bae44b2).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3506      +/-   ##
==========================================
- Coverage   82.31%   82.29%   -0.03%     
==========================================
  Files         614      614              
  Lines       36885    36885              
  Branches     6051     6046       -5     
==========================================
- Hits        30361    30353       -8     
- Misses       5629     5635       +6     
- Partials      895      897       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marksvc
Copy link
Collaborator Author

marksvc commented Oct 10, 2025

The getShortAudioBlob had the same sound as test-audio-short.mp3, but getShortAudioBlob is a wav.

@marksvc marksvc marked this pull request as ready for review October 10, 2025 22:05
@pmachapman pmachapman self-requested a review October 12, 2025 21:31
@pmachapman pmachapman self-assigned this Oct 12, 2025
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: I will miss the "click"!

@pmachapman reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @marksvc)

@pmachapman pmachapman merged commit 75f33fc into master Oct 12, 2025
23 checks passed
@pmachapman pmachapman deleted the task/sample-audio branch October 12, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants