Skip to content

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Sep 28, 2025

I put each logical change into a separate commit. I'd recommend to review them separately.
Some of them are just incremental module renames to make it easier to review "event" -> "message" and "trigger" -> "event" types of rename.

@Shatur Shatur force-pushed the bevy-0.17 branch 6 times, most recently from 5f5dbcb to cb1f9ea Compare October 1, 2025 23:29
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 73.24324% with 198 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.30%. Comparing base (76eb4f1) to head (37a9415).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/shared/message/server_message.rs 70.16% 54 Missing ⚠️
src/client/message.rs 36.84% 36 Missing ⚠️
src/shared/message/client_message.rs 75.45% 27 Missing ⚠️
src/server/message.rs 73.03% 24 Missing ⚠️
src/shared/message/message_fns.rs 71.18% 17 Missing ⚠️
src/server/server_world.rs 75.00% 8 Missing ⚠️
src/shared/message/server_event.rs 87.09% 8 Missing ⚠️
src/shared/message/client_event.rs 86.04% 6 Missing ⚠️
src/compact_entity.rs 73.33% 4 Missing ⚠️
src/server.rs 71.42% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
- Coverage   78.36%   78.30%   -0.06%     
==========================================
  Files          57       56       -1     
  Lines        3235     3240       +5     
==========================================
+ Hits         2535     2537       +2     
- Misses        700      703       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Shatur Shatur marked this pull request as ready for review October 2, 2025 00:03
@Shatur Shatur requested a review from UkoeHB October 2, 2025 00:07
Shatur added 20 commits October 2, 2025 13:49
For details see bevyengine/bevy#19121
bevyengine/bevy#18704

The niche is now in the index, which makes the compression logic even
simpler.
- State now initialized separately.
- Updating archetype access no longer needed.
- `new_archetype` no longer exists and archetype cache needs to be
  updated in `get_param`.
- `ReplicationRules` resource no longer need to be cloned.

For details see bevyengine/bevy#16885
bevyengine/bevy#19143
- Messages and events work, but `trigger_targets` does nothing.
- Updated naming across the project, except in the `event` modules.

Remote events and messages require re-architecture. We no longer need to
buffer events or use custom methods to trigger them. That's why the
naming in `event` remains unchanged, with several TODOs left in place.
We no longer need custom sed/de to additionally serialize targets. This
allows us to express things a bit nicer using conversion traits.
No other type or variable name changes.
No type or variable name changes.
Copy link
Collaborator

@UkoeHB UkoeHB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, can merge once fixed

Copy link
Contributor Author

@Shatur Shatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Shatur Shatur enabled auto-merge (squash) October 3, 2025 07:51
@Shatur Shatur merged commit 657ac21 into master Oct 3, 2025
10 checks passed
@Shatur Shatur deleted the bevy-0.17 branch October 3, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants